Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logcli docker image #2561

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Conversation

tharun208
Copy link
Contributor

What this PR does / why we need it:
This PR introduces the docker image for logcli
Which issue(s) this PR fixes:
Fixes #1751

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2020

Codecov Report

Merging #2561 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2561      +/-   ##
==========================================
+ Coverage   62.80%   62.86%   +0.05%     
==========================================
  Files         162      162              
  Lines       13966    13966              
==========================================
+ Hits         8772     8780       +8     
+ Misses       4512     4500      -12     
- Partials      682      686       +4     
Impacted Files Coverage Δ
pkg/promtail/targets/file/tailer.go 73.86% <0.00%> (-2.28%) ⬇️
pkg/querier/queryrange/downstreamer.go 95.87% <0.00%> (-2.07%) ⬇️
pkg/promtail/targets/file/filetarget.go 67.85% <0.00%> (-1.79%) ⬇️
pkg/promtail/positions/positions.go 59.64% <0.00%> (+13.15%) ⬆️

cmd/logcli/Dockerfile Outdated Show resolved Hide resolved
@slim-bean
Copy link
Collaborator

Hey @tharun208 thanks for the PR!

For the drone generation, we use jsonnet to define the jobs and then auto-generate the yaml using make drone

Could you look at updating drone.jsonnet (I think hopefully it's as easy as adding logcli to the list of apps at the top) and then run make drone to generate the drone.yaml file?

Signed-off-by: Tharun <rajendrantharun@live.com>
@tharun208
Copy link
Contributor Author

Hey @tharun208 thanks for the PR!

For the drone generation, we use jsonnet to define the jobs and then auto-generate the yaml using make drone

Could you look at updating drone.jsonnet (I think hopefully it's as easy as adding logcli to the list of apps at the top) and then run make drone to generate the drone.yaml file?

@slim-bean regenerated the drone.yml and updated drone.jsonnet 👍

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks @tharun208 !

@slim-bean slim-bean merged commit ab2dc9e into grafana:master Sep 1, 2020
@tharun208 tharun208 deleted the logcli-dockerimage branch September 1, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide logcli docker image
4 participants