-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logcli docker image #2561
Conversation
2996861
to
7365818
Compare
c03d369
to
b7ce25d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
==========================================
+ Coverage 62.80% 62.86% +0.05%
==========================================
Files 162 162
Lines 13966 13966
==========================================
+ Hits 8772 8780 +8
+ Misses 4512 4500 -12
- Partials 682 686 +4
|
b7ce25d
to
9c250c0
Compare
Hey @tharun208 thanks for the PR! For the drone generation, we use jsonnet to define the jobs and then auto-generate the yaml using Could you look at updating drone.jsonnet (I think hopefully it's as easy as adding logcli to the list of apps at the top) and then run |
Signed-off-by: Tharun <rajendrantharun@live.com>
9c250c0
to
a4feb55
Compare
@slim-bean regenerated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks @tharun208 !
What this PR does / why we need it:
This PR introduces the docker image for logcli
Which issue(s) this PR fixes:
Fixes #1751
Special notes for your reviewer:
Checklist