Avoid parsing labels when tailer is sending from a stream. #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also include some code cleanup. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2973 +/- ##
==========================================
- Coverage 61.84% 61.79% -0.06%
==========================================
Files 182 182
Lines 14870 14863 -7
==========================================
- Hits 9197 9184 -13
- Misses 4824 4834 +10
+ Partials 849 845 -4
|
owen-d
approved these changes
Nov 24, 2020
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Move regex opt to after lookup fixes grafana#2906 When we use the caching client (which is what is used in most cases), we load the entire row (tableName+HashKey) irrespective of what the rangeKey parameters are. Which means with the optimisation, we are loading the same row multiple times and then operating on the same data. This PR moves the optimisation to after the data is loaded which should be faster. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Add benchmark Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Add changelog entry Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Address feedback Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also include some code cleanup.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com