Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs PushRequest data. #3178

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Logs PushRequest data. #3178

merged 3 commits into from
Jan 15, 2021

Conversation

cyriltovena
Copy link
Contributor

This will allows to find information about received size and total entries per tenant.

Example of a log from my dev testing:

level=debug ts=2021-01-15T11:16:21.735663076Z caller=http.go:67 org_id=3927 traceID=11c4774c6ec4bbf4 msg="push request parsed" path=/loki/api/v1/push content-type=application/x-protobuf body-size="11 kB" streams=5 entries=298 streamLabelsSize="1.9 kB" entriesSize="45 kB" totalSize="47 kB"

Of course this means we can use LogQL on this.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

This will allows to find information about received size and total entries per tenant.

Example of a log from my dev testing:

```
level=debug ts=2021-01-15T11:16:21.735663076Z caller=http.go:67 org_id=3927 traceID=11c4774c6ec4bbf4 msg="push request parsed" path=/loki/api/v1/push content-type=application/x-protobuf body-size="11 kB" streams=5 entries=298 streamLabelsSize="1.9 kB" entriesSize="45 kB" totalSize="47 kB"
```

Of course this means we can use LogQL on this.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #3178 (8f87f7b) into master (322e4bc) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3178      +/-   ##
==========================================
- Coverage   63.25%   63.15%   -0.10%     
==========================================
  Files         188      189       +1     
  Lines       16304    16332      +28     
==========================================
+ Hits        10313    10315       +2     
- Misses       5051     5077      +26     
  Partials      940      940              
Impacted Files Coverage Δ
pkg/distributor/http.go 0.00% <0.00%> (ø)
pkg/util/reader.go 0.00% <0.00%> (ø)
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 15, 2021
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@owen-d owen-d merged commit 28c0b31 into grafana:master Jan 15, 2021
cyriltovena added a commit to cyriltovena/loki that referenced this pull request Jan 26, 2021
Lost during a merge/rebase of grafana@6cc41f9 🤷

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena added a commit that referenced this pull request Jan 26, 2021
Lost during a merge/rebase of 6cc41f9 🤷

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena added a commit to cyriltovena/loki that referenced this pull request Jan 26, 2021
Lost during a merge/rebase of grafana@6cc41f9 🤷

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants