Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: enable environment variable in configuration #3385

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

paaacman
Copy link
Contributor

@paaacman paaacman commented Feb 25, 2021

What this PR does / why we need it:
Add in promtail documentation that environment variable in configuration works only if promtail is started with -config.expand-env=true option.

Which issue(s) this PR fixes:
Fix #3023

Special notes for your reviewer:
Should we add Note: This feature is only available in Loki 2.1+. too, as in Grafana documentation?
Sorry if this PR miss something, it's my first PR to an open source documentation.

Checklist

  • Documentation added
  • Tests updated

Environment variable in configuration works only if promtail is started with `-config.expand-env=true` option.
Should we add `Note: This feature is only available in Loki 2.1+.` too?
@CLAassistant
Copy link

CLAassistant commented Feb 25, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @paaacman :)

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slim-bean slim-bean merged commit 93f1966 into grafana:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promtail configuration support for environment variable interpolation not working as documented
4 participants