From d372ed94f5a8948b9fcd9cf7abc86fe9ad8ae09e Mon Sep 17 00:00:00 2001 From: Cyril Tovena Date: Thu, 4 Mar 2021 09:54:19 +0100 Subject: [PATCH] Improve the parser hint tests. I was able to find out where was the issue with that test yesterday. Now I realized that we can mutate (re-slice) the given log line, and so other test would fail. This also make the parallel back. Signed-off-by: Cyril Tovena --- pkg/logql/log/parser_hints_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/logql/log/parser_hints_test.go b/pkg/logql/log/parser_hints_test.go index b32d9285206bd..fc639461ca823 100644 --- a/pkg/logql/log/parser_hints_test.go +++ b/pkg/logql/log/parser_hints_test.go @@ -41,6 +41,8 @@ var ( ) func Test_ParserHints(t *testing.T) { + lbs := labels.Labels{{Name: "app", Value: "nginx"}, {Name: "cluster", Value: "us-central-west"}} + t.Parallel() for _, tt := range []struct { expr string @@ -206,13 +208,13 @@ func Test_ParserHints(t *testing.T) { } { tt := tt t.Run(tt.expr, func(t *testing.T) { - lbs := labels.Labels{{Name: "app", Value: "nginx"}, {Name: "cluster", Value: "us-central-west"}} + t.Parallel() expr, err := logql.ParseSampleExpr(tt.expr) require.NoError(t, err) ex, err := expr.Extractor() require.NoError(t, err) - v, lbsRes, ok := ex.ForStream(lbs).Process(tt.line) + v, lbsRes, ok := ex.ForStream(lbs).Process(append([]byte{}, tt.line...)) var lbsResString string if lbsRes != nil { lbsResString = lbsRes.String()