Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better operational dashboard annotations via diff logger #3697

Merged
merged 1 commit into from
May 6, 2021
Merged

better operational dashboard annotations via diff logger #3697

merged 1 commit into from
May 6, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented May 6, 2021

This moves away from bad practice custom diff logger promtail configs that created too many streams and should work with a reasonably default config.

slim-bean
slim-bean approved these changes May 6, 2021
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 03aab3d into grafana:main May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owen-d @slim-bean