docs: http_path_prefix as correct item of server_config #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the approval @KMiller-Grafana |
|
@sanadhis I've tagged the team to do a review/merge in. I also do not have merge permissions. |
sandeepsukhani
previously requested changes
Jun 22, 2021
sanadhis
force-pushed
the
feature/docs-http-path-prefix
branch
from
c0e01f0
to
3875d4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In https://grafana.com/docs/loki/latest/configuration/, the sub-server yaml key to configure base path for API routes should be
http_path_prefixinstead ofhttp_prefix. This PR fixes the documentation.Which issue(s) this PR fixes:
Not sure there is related issue yet.
Special notes for your reviewer:
My first PR in open-source world. Apologize if missing some details 😟
Checklist