Docs: minor improvements to Loki Canary docs #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reduce size of canary drawing - add a description of what Loki Canary does - update wording of the configuration options - minor grammar improvements throughout the section
owen-d
approved these changes
Aug 31, 2021
cstyan
reviewed
Aug 31, 2021
| @@ -77,15 +83,16 @@ log lines be sure not to set the two out of order time range flags too far in th | |||
| The defaults are already enough to test this functionality properly, and setting them | |||
| too far in the past can cause issues with the spot check test. | |||
|
|
|||
| When using `out-of-order-percentage`, you also need to make use of pipeline stages | |||
|
|
|||
There was a problem hiding this comment.
was there supposed to be an extra newline here?
There was a problem hiding this comment.
Didn't hurt anything. But probably no, an extra newline was not needed there. We can remove it the next time we touch this section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the extra irrelevant commits on the PR; please ignore; the diff is correct.