Ruler: improve control over marshaling relabel.Config #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abel.Config struct Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
sandeepsukhani
approved these changes
Sep 22, 2021
kavirajk
approved these changes
Sep 22, 2021
dannykopping
pushed a commit
that referenced
this pull request
Sep 27, 2021
…abel.Config struct (#4364) Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Kopping danny.kopping@grafana.com
What this PR does / why we need it:
This PR introduces a custom struct that eases json/yaml unmarshaling of complex relabel.Config struct.
Since we use
jsonto marshal our per-tenant limits inentitlements, and prometheus doesn't have a custom JSON unmarshaler, we need to introduce our own.I also opted to only accept primitive types and push the responsibility of using the correct types down to the
createRelabelConfigsfunction.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
We do the YAML marshal/unmarshal dance because prometheus only validates the configuration in its
UnmarshalYAMLfunction.Checklist