Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add on and ignoring clauses in binOpExpr #4391

Merged
merged 6 commits into from
Oct 5, 2021
Merged

add on and ignoring clauses in binOpExpr #4391

merged 6 commits into from
Oct 5, 2021

Commits on Oct 2, 2021

  1. add on and ignoring clauses in binOpExpr

    @garrettlish
    garrettlish authored and garrettlish committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    11573cc View commit details
    Browse the repository at this point in the history

  2. add on/ignoring new operator shardmapper unit test

    @garrettlish
    garrettlish committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    0035ee3 View commit details
    Browse the repository at this point in the history

  3. add doc for on and ignoring keywords

    @garrettlish
    garrettlish committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    73bcb19 View commit details
    Browse the repository at this point in the history

  4. resolve comments 

    * use a scoped error to replace mutate stepEvaluator via type switching
* change VectorMatching Include from empty string array to nil
* prohibit sharding when we're changing the label groupings such as on or ignoring
* add unit test to cover multiple matches for labels error
* fix expr.y format issue
    @garrettlish
    garrettlish committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    8f2e0b5 View commit details
    Browse the repository at this point in the history

  5. resolve comments 

    * reformat on and ignoring keywords doc
* add sharding unit test for on and ignoring keywords
    @garrettlish
    garrettlish committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    48314f3 View commit details
    Browse the repository at this point in the history

  6. resolve comments: add a sentence for each example to help docs reader… 

    …s to understand the larger picture
    @garrettlish
    garrettlish committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    8064e3d View commit details
    Browse the repository at this point in the history