Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add virtual targets docs #4565

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

DylanGuedes
Copy link
Contributor

What this PR does / why we need it:
Document the new hybrid mode, that allows running Loki with target=write and target=read.

Which issue(s) this PR fixes:
Fixes #4544

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated (N/A)

@DylanGuedes DylanGuedes force-pushed the add-virtual-targets-docs branch 2 times, most recently from e2370bd to 7cd3d4f Compare October 27, 2021 14:07
@pull-request-size pull-request-size bot added size/M and removed size/L labels Oct 27, 2021
@DylanGuedes DylanGuedes marked this pull request as ready for review October 27, 2021 14:15
@DylanGuedes
Copy link
Contributor Author

The rendered markdown is available here.

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question

docs/sources/configuration/_index.md Outdated Show resolved Hide resolved
@dannykopping
Copy link
Contributor

@DylanGuedes would it be possible to add a white background to that image? I use GH in dark mode, and it's not very legible with the transparent background.

- Update targets with new 'read' and 'write' options
- Add new docker-compose yaml that exemplifies how to use new 'read' and
  'write' targets
@DylanGuedes
Copy link
Contributor Author

@DylanGuedes would it be possible to add a white background to that image? I use GH in dark mode, and it's not very legible with the transparent background.

Sure! I've amended the last commit with the change, LMK if it is more legible in dark mode now.

- Missing ones: index-gateway, ingester-querier, query-scheduler
@dannykopping dannykopping merged commit 331fa6d into grafana:main Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document new virtual targets
2 participants