Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding recording rules dashboard #4575

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

dannykopping
Copy link
Contributor

@dannykopping dannykopping commented Oct 28, 2021

Signed-off-by: Danny Kopping danny.kopping@grafana.com

What this PR does / why we need it:
Follow up to #4566, adding a basic recording rules dashboard

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
Preview:
image

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@dannykopping dannykopping marked this pull request as ready for review October 28, 2021 13:32
@dannykopping dannykopping requested a review from a team as a code owner October 28, 2021 13:32
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 9ad05f2 into grafana:main Oct 28, 2021
@cstyan
Copy link
Contributor

cstyan commented Oct 28, 2021

Sorry, missed this PR. @dannykopping can we make sure the recording rules dashboard here has the links update I made in the mixin/other locations? Let me know if you want me to do this.

@dannykopping
Copy link
Contributor Author

Sorry, missed this PR. @dannykopping can we make sure the recording rules dashboard here has the links update I made in the mixin/other locations? Let me know if you want me to do this.

We won't use this dashboard; it's just for OSS; do I still need those links in that case?

@dannykopping dannykopping deleted the dannykopping/rr-dashboard branch October 29, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants