From 12ccec5c044a24fa18e0f3f5cd2b7e04e0afa4fa Mon Sep 17 00:00:00 2001 From: Owen Diehl Date: Wed, 3 Nov 2021 08:42:12 -0400 Subject: [PATCH 1/2] default wal to enabled --- production/ksonnet/loki/config.libsonnet | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/production/ksonnet/loki/config.libsonnet b/production/ksonnet/loki/config.libsonnet index d1a1cc0602f01..3821ab7018c57 100644 --- a/production/ksonnet/loki/config.libsonnet +++ b/production/ksonnet/loki/config.libsonnet @@ -12,11 +12,12 @@ // flag for tuning things when boltdb-shipper is current or upcoming index type. using_boltdb_shipper: true, - wal_enabled: false, + wal_enabled: true, query_scheduler_enabled: false, overrides_exporter_enabled: false, // flags for running ingesters/queriers as a statefulset instead of deployment type. + // WAL enabled configurations automatically use statefulsets. stateful_ingesters: false, ingester_pvc_size: '10Gi', ingester_pvc_class: 'fast', From dffa3bba0ed8d3973ce675c48d1952a6e83eb643 Mon Sep 17 00:00:00 2001 From: Owen Diehl Date: Wed, 3 Nov 2021 08:47:20 -0400 Subject: [PATCH 2/2] update changelog & upgrade.md --- CHANGELOG.md | 1 + docs/sources/upgrading/_index.md | 2 ++ 2 files changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 03cd0bdf1b846..c828f5301c894 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ * [4574](https://github.com/grafana/loki/pull/4574) **slim-bean**: Loki: Add a ring to the compactor used to control concurrency when not running standalone * [4603](https://github.com/grafana/loki/pull/4603) **garrettlish**: Add date time sprig template functions in logql label/line formatter * [4608](https://github.com/grafana/loki/pull/4608) **trevorwhitney**: Change default value of ingester lifecycler's `final_sleep` from `30s` to `0s` +* [4629](https://github.com/grafana/loki/pull/4629) **owen-d**: Default the WAL to enabled in the Loki jsonnet library # 2.3.0 (2021/08/06) diff --git a/docs/sources/upgrading/_index.md b/docs/sources/upgrading/_index.md index de720d125209d..11a6992af0c24 100644 --- a/docs/sources/upgrading/_index.md +++ b/docs/sources/upgrading/_index.md @@ -28,6 +28,8 @@ This changes the default value for the `final_sleep` property of the ingester's #### Ingester WAL now defaults to on, and chunk transfers are disabled by default * [4543](https://github.com/grafana/loki/pull/4543) **trevorwhitney**: Change more default values and improve application of common storage config +* [4629](https://github.com/grafana/loki/pull/4629) **owen-d**: Default the WAL to enabled in the Loki jsonnet library +* [4624](https://github.com/grafana/loki/pull/4624) **chaudum**: Disable chunk transfers in jsonnet lib This changes a few default values, resulting in the ingester WAL now being on by default, and chunk transfer retries are disabled by default. Note, this now means Loki will depend on local disk by default for it's WAL (write ahead log) directory. This defaults to `wal` but can be overridden via the `--ingester.wal-dir` or via `path_prefix` in the common configuration section. Below are config snippets with the previous defaults, and another with the new values.