Loki: Revert distributor defaulting to inmemory
#4638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [PR 4440](https://github.com/grafana/loki/pull/4440/files) modified the distributor setup to use inmemory by default (instead of consul). That was necessary because, by changing the default rate limiting to global, a ring was necessary, and since by default the ring was set to consul, the project couldn't run with the default configs. That's not the case anymore: right now we are reusing the same config set for the ingester (which users already have properly configured otherwise they wouldn't be able to run the project). List of changes: - Remove changelog entries - Remove upgrading guide entries - Remove added tests (unnecessary checks) - Remove value overriding
owen-d
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
inmemory(instead of consul). This is inconsistent with other rings default behavior and is also not retrocompatible with previous versions.global, a ring was necessary, and, since by default the ring KV wasconsul, the project couldn't run with the default configs. That's not the case anymore: right now we are defaulting to reusing the ingester config, which users already have properly configured otherwise they wouldn't be able to run the project anyway.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Checklist
CHANGELOG.mdabout the changes.