Add SASL&mTLS authentication support for Kafka in Promtail #4663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO
|
taisho6339
force-pushed
the
feature/add-authentication-for-kafka
branch
from
9574df7
to
cacf104
Compare
taisho6339
changed the title
taisho6339
force-pushed
the
feature/add-authentication-for-kafka
branch
from
cacf104
to
0bad5ed
Compare
* Add test stacks for SSL, SASL/PLAIN, SASL/SCRAM, SASL over TLS authentication
taisho6339
force-pushed
the
feature/add-authentication-for-kafka
branch
from
34212a1
to
488fae3
Compare
taisho6339
force-pushed
the
feature/add-authentication-for-kafka
branch
from
c66d3c5
to
d2f4a58
Compare
taisho6339
changed the title
|
Fixed |
cyriltovena
reviewed
Nov 8, 2021
There was a problem hiding this comment.
Nice contribution @taisho6339. Went through the code once and it looks awesome. I'll run it locally this week and circle back.
|
Thank you so much! |
cyriltovena
approved these changes
Nov 9, 2021
|
Maybe we need to add "host.docker.internal" as SAN field in create certs script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, Promtail doesn't support Kafka authentication so we can only connect with no auth.
Let me suggest changes to add some authentication for Kafka.
This PR adds the following auth method.
In addition,
Most of the changes are due to additional modules and testing tools.
Which issue(s) this PR fixes:
Fixes #4662
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.