filters: use faster regexp package #5315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies some optimisations I have submitted to the Go project:
I have a FOSDEM talk on Saturday 6th Feb about this.
I collected the optimisations into a new repo https://github.com/grafana/regexp; it exists purely to make PRs like this possible and can be retired once the changes land upstream.
I also added some new benchmark cases, because all the existing ones don't actually reach the regexp package after 'simplification'.
The benchmark is now running each case once for each iteration instead of a million times; this makes it easier to control the time and to read the averages.
Checklist
CHANGELOG.md
about the changes.