Fix apply retention issue #5342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepsukhani
force-pushed
the
fix-apply-retention-issue
branch
from
e789126
to
59bbc17
Compare
sandeepsukhani
added a commit
that referenced
this pull request
Feb 10, 2022
* call mark phase started/finished only when applying retention * correctly pass userID to IntervalMayHaveExpiredChunks call on retention and dletion expiry check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have
MarkPhaseStartedandMarkPhaseEndedcalls to notify retention and deletion expiry checker about start/end of chunk mark phase before applying retention. WhenMarkPhaseStartedis called on the deletion expiry checker, it would load all the delete requests to process andMarkPhaseEndedwould mark those delete requests as processed.We recently added a config to run mark phase at a different interval than compaction interval so it means we do not always apply retention when running compaction, based on the config. The bug here we have is we were always calling
MarkPhaseStartedandMarkPhaseEndedwhich was causing the delete requests to be marked as processed even without processing them.This also fixes another bug in the consolidated
IntervalMayHaveExpiredChunkswhich was not passinguserIDto downstream retention and deletion expiry checker.