Introduce a ChunkRef type as part of logproto #5643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
changed the title
simonswine
force-pushed
the
20220316_introduce-proto-chunkref
branch
from
2964c14
to
de59c13
Compare
simonswine
commented
Mar 16, 2022
| @@ -2,7 +2,7 @@ syntax = "proto3"; | |||
|
|
|||
| package ingesterpb; | |||
|
|
|||
| option go_package = "client"; | |||
| option go_package = "github.com/grafana/loki/pkg/ingester/client"; | |||
There was a problem hiding this comment.
This should be the full go path to the package rather than just client
simonswine
force-pushed
the
20220316_introduce-proto-chunkref
branch
2 times, most recently
from
4ec8a22
to
4167dc1
Compare
simonswine
force-pushed
the
20220316_introduce-proto-chunkref
branch
from
4167dc1
to
4031dba
Compare
simonswine
force-pushed
the
20220316_introduce-proto-chunkref
branch
from
4031dba
to
c4233a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds a ChunkRef protobuf type as a part of logproto.
Special notes for your reviewer:
In follow up PRs I plan to:
Checksumfield (keeping the size of the refactoring small per PR)ChunkRefwith the one from logproto:loki/pkg/storage/tsdb/index.go
Lines 17 to 22 in 8c06c54
Checklist
- [ ] Documentation added- [ ] Tests updated- [ ] Add an entry in theCHANGELOG.mdabout the changes.