Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump inet.af/netaddr for Go 1.18 compatibility #5872

Merged
merged 1 commit into from
May 2, 2022
Merged

Bump inet.af/netaddr for Go 1.18 compatibility #5872

merged 1 commit into from
May 2, 2022

Conversation

foutrelis
Copy link
Contributor

Fixes panic caused by outdated go4.org/unsafe/assume-no-moving-gc. [1]

[1] assume-no-moving-gc commit 538ce61f45ea5c2c48d7133d44b3e52c3db5c31e

What this PR does / why we need it:

Allows Loki to be built with Go 1.18.

Checklist

  • [-] Documentation added
  • [-] Tests updated
  • [] Add an entry in the CHANGELOG.md about the changes.

Fixes panic caused by outdated go4.org/unsafe/assume-no-moving-gc. [1]

[1] assume-no-moving-gc commit 538ce61f45ea5c2c48d7133d44b3e52c3db5c31e
@foutrelis foutrelis requested a review from a team as a code owner April 11, 2022 20:26
@CLAassistant
Copy link

CLAassistant commented Apr 11, 2022

CLA assistant check
All committers have signed the CLA.

@foutrelis foutrelis changed the title Bump inet.af/netaddr for go 1.18 compatibility Bump inet.af/netaddr for Go 1.18 compatibility Apr 11, 2022
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 093fe91 into grafana:main May 2, 2022
@foutrelis foutrelis deleted the go1.18 branch May 2, 2022 08:31
@foutrelis
Copy link
Contributor Author

Looks like an empty commit was made, likely because #6046 was merged a few days ago with the same changes.

Oh well, no harm done I guess. 🐭️

@cyriltovena
Copy link
Contributor

Yeah no worries !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants