Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logcli: Respect quiet flag in logcli tail.go #6033

Merged
merged 1 commit into from
May 2, 2022

Conversation

DylanGuedes
Copy link
Contributor

@DylanGuedes DylanGuedes commented Apr 26, 2022

What this PR does / why we need it:
This PR changes logcli tailing to check if the quiet flag is false before logging not critical messages.

Which issue(s) this PR fixes:
Fixes #4124

Special notes for your reviewer:
N/A\

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@andsens
Copy link
Contributor

andsens commented Apr 26, 2022

You probably meant to link #4124

@DylanGuedes
Copy link
Contributor Author

You probably meant to link #4124

oops, thank you! 😄

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logcli: Respect --quiet when tailing
3 participants