[bugfix] add Promtail cloudflare close #7394
Conversation
| @@ -158,6 +158,9 @@ func (t *Target) pull(ctx context.Context, start, end time.Time) error { | |||
| level.Warn(t.logger).Log("msg", "failed iterating over logs, out of cloudflare range, not retrying", "err", err, "start", start, "end", end, "retries", backoff.NumRetries()) | |||
| return nil | |||
| } else if err != nil { | |||
| if it != nil { | |||
There was a problem hiding this comment.
Will it be possible to add a test for this?
|
done |
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
done, thanks |
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
thanks. |
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0.1%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. - ingester -0.1%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
**What this PR does / why we need it**: If the http server closes the connection, the client may also return a non-empty reader io.ReadCloser. **Which issue(s) this PR fixes**: Fixes grafana#6150 Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
**What this PR does / why we need it**: If the http server closes the connection, the client may also return a non-empty reader io.ReadCloser. **Which issue(s) this PR fixes**: Fixes grafana#6150 Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
What this PR does / why we need it:
If the http server closes the connection, the client may also return a non-empty reader io.ReadCloser.
Which issue(s) this PR fixes:
Fixes #6150
Special notes for your reviewer:
package cloudflare
func makeRequestWithAuthTypeAndHeaders()
I try to mock server-side closing connection error through Close() and LogpullReceivedError.
Although it is not perfect, I can only simulate such an error for the time being.
test without this pr.
Checklist
CONTRIBUTING.mdguideCHANGELOG.mdupdateddocs/sources/upgrading/_index.md