Feature: Add extra containers to loki helm chart #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@angelbarrera92 Thanks for this can you rebase and bump correctly each chart please ? |
|
@cyriltovena rebased and bumped version |
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
* Add extra containers feature to loki chart * minor bump version to loki helm charts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This merge request adds the possibility to define sidecar containers to loki stateful set. Makes easy to deploy a loki server in a multi-tenant way.
Which issue(s) this PR fixes:
Fixes #908
Special notes for your reviewer:
I can build a go proxy like: https://github.com/angelbarrera92/basic-auth-reverse-proxy/tree/feature/grafana_loki_multitenant and write about the POC i did if you want!
Checklist
Added at chart values file for each new input
Thanks!