Unify direct and caching RuleStores in ruler
#9434
Draft
+144
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
commented
Sep 26, 2024
| opts = append(opts, rulestore.WithCacheDisabled()) | ||
| } | ||
|
|
||
| users, err := r.store.ListAllUsers(ctx, opts...) |
There was a problem hiding this comment.
Passing the cache/don't cache option here doesn't actually affect anything since we specifically configure tenant listing calls to not be cached but it doesn't hurt to make that explicit here in case we change the config in the future.
Instead of using two different `RuleStore` implementations within the Ruler, use a single caching implementation and selectively disable caching when required. This change removes the "direct" `RuleStore` implementation from the Ruler's gRPC and HTTP API layers. Instead, the caching implementation is used for all calls. In cases where caching returning stale results would not be acceptable, the caching is disabled _just_ for that call. This allows rule group contents to be safety cached with the understanding that it is safe to cache them because they will correctly invalidated when deleted or modified. Part of #9386
4 tasks
56quarters
force-pushed
the
56quarters/ruler-caching
branch
from
3e4ad55
to
f7039db
Compare
56quarters
commented
Sep 26, 2024
| @@ -294,7 +294,7 @@ std.manifestYamlDoc({ | |||
|
|
|||
| memcached:: { | |||
| memcached: { | |||
| image: 'memcached:1.6.19-alpine', | |||
| image: 'memcached:1.6.28-alpine', | |||
There was a problem hiding this comment.
Unrelated but I needed to be able to watch deletions which was only available in a newer version and this matches what we run in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Instead of using two different
RuleStoreimplementations within the Ruler, use a single caching implementation and selectively disable caching when required.This change removes the "direct"
RuleStoreimplementation from the Ruler's gRPC and HTTP API layers. Instead, the caching implementation is used for all calls. In cases where caching returning stale results would not be acceptable, the caching is disabled just for that call.This allows rule group contents to be safety cached with the understanding that it is safe to cache them because they will correctly invalidated when deleted or modified.
Which issue(s) this PR fixes or relates to
Part of #9386
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.