Chore: Extract CustomTrackersConfig from the activeseries package. #9435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ying-jeanne
changed the title
ying-jeanne
force-pushed
the
split-model
branch
from
4e6e471
to
5d71a71
Compare
ying-jeanne
changed the title
ying-jeanne
force-pushed
the
split-model
branch
from
5d71a71
to
fcc545e
Compare
ying-jeanne
commented
Sep 26, 2024
| // matches returns a PreAllocDynamicSlice containing only matcher indexes which are matching | ||
| func (m *Matchers) matches(series labels.Labels) preAllocDynamicSlice { | ||
| // Matches returns a PreAllocDynamicSlice containing only matcher indexes which are matching | ||
| func (m *Matchers) Matches(series labels.Labels) PreAllocDynamicSlice { |
There was a problem hiding this comment.
had to change functions to public since they are used in activeseries package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This pull request seeks to extract the CustomTrackersConfig struct from the activeseries package. The reason for this is that pkg/util/validation depends on github.com/grafana/mimir/pkg/ingester/activeseries. If we introduce any services invoked by activeseries, they won't be able to depend on validation.Overrides, since it would result in a circular import problem.
In this PR, I've introduced activeseriesmodel, which will be utilized by both activeseries and validation. The entire PR should be Noop
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.