Refactor query editor code #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9bf7cbc.
Contributor
Author
|
reverting last commit until that's fixed at grafana/athena-datasource#69 |
sunker
approved these changes
Oct 7, 2021
Collaborator
sunker
left a comment
sunker
left a comment
There was a problem hiding this comment.
LGTM
The issue is now solved but IMO we should not even use the onSave hook, that should save the dashboard, not just run it.
+1 for that. If we could use F5, like in any other SQL editor, that would be nice.
Collaborator
|
BTW shouldn't we move the macros to the left side of the editor? Using the same layout as in Athena |
Contributor
Author
That would help with standardization yes (even though for Redshift is only Table/Column atm, not like all the options that Athena has). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81
The changes are:
QueryEditorcode in two, adding the componentQueryEditorCodethat is used as a Custom Variable editor.SchemaInfoclass that I took from the TimeStream data source but that class was quite complicated and using old react hooks. I used that approach because it was the only way I found to make theonSavemethod work in the editor. See this issue for more details. The issue is now solved but IMO we should not even use theonSavehook, that should save the dashboard, not just run it. Now it's just usingSuggestionsas Athena does.