From 1ee12f73f51945c68f35fd0eaeea23699f4790b8 Mon Sep 17 00:00:00 2001 From: Martin Disibio Date: Thu, 21 Nov 2024 17:12:37 -0500 Subject: [PATCH] changelog --- CHANGELOG.md | 1 + pkg/traceql/engine_metrics.go | 6 +----- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a3fbb467f8f..2698a27358e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -68,6 +68,7 @@ * [BUGFIX] Pushes a 0 to classic histogram's counter when the series is new to allow Prometheus to start from a non-null value. [#4140](https://github.com/grafana/tempo/pull/4140) (@mapno) * [BUGFIX] Fix counter samples being downsampled by backdate to the previous minute the initial sample when the series is new [#4236](https://github.com/grafana/tempo/pull/4236) (@javiermolinar) * [BUGFIX] Fix traceql metrics time range handling at the cutoff between recent and backend data [#4257](https://github.com/grafana/tempo/issues/4257) (@mdisibio) +* [BUGFIX] Fix several issues with exemplar values for traceql metrics [#4366](https://github.com/grafana/tempo/pull/4366) (@mdisibio) * [BUGFIX] Skip computing exemplars for instant queries. [#4204](https://github.com/grafana/tempo/pull/4204) (@javiermolinar) * [BUGFIX] Gave context to orphaned spans related to various maintenance processes. [#4260](https://github.com/grafana/tempo/pull/4260) (@joe-elliott) * [BUGFIX] Utilize S3Pass and S3User parameters in tempo-cli options, which were previously unused in the code. [#4259](https://github.com/grafana/tempo/pull/4259) (@faridtmammadov) diff --git a/pkg/traceql/engine_metrics.go b/pkg/traceql/engine_metrics.go index 428df5ae4c4..94148cd3726 100644 --- a/pkg/traceql/engine_metrics.go +++ b/pkg/traceql/engine_metrics.go @@ -1233,13 +1233,9 @@ func (b *SimpleAggregator) aggregateExemplars(ts *tempopb.TimeSeries, existing * Value: StaticFromAnyValue(l.Value), }) } - value := exemplar.Value - /*if math.IsNaN(value) { - value = 0 // TODO: Use the value of the series at the same timestamp - }*/ existing.Exemplars = append(existing.Exemplars, Exemplar{ Labels: labels, - Value: value, + Value: exemplar.Value, TimestampMs: uint64(exemplar.TimestampMs), }) }