Upgrade dskit to the version without log.Interface and logrus #2796
+8,091
−2,354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
duricanikolic
force-pushed
the
yuri/dskit-log
branch
2 times, most recently
from
eae92a4
to
ec493a2
Compare
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/dskit-log
branch
from
ec493a2
to
95ee1da
Compare
|
This PR has been automatically marked as stale because it has not had any activity in the past 60 days. |
duricanikolic
added
the
keepalive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR upgrades
dskitand usesdskit'slogpackage for the creation of the global logger.For the main in the
dskitsee grafana/dskit#359.Moreover, it removes
RateLimitedLoggerfromtempoand replaces it withdskit's equivalent.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]