Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix invalid query #2857

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Docs: Fix invalid query #2857

merged 2 commits into from
Aug 28, 2023

Conversation

fabrizio-grafana
Copy link
Contributor

@fabrizio-grafana fabrizio-grafana commented Aug 28, 2023

What this PR does:
Query { error = true } | by(resource.service.name) | count() > 1, reported in the online documentation, seems to be invalid:
Screenshot 2023-08-28 at 15 50 02

This PR proposes to replace it with { status = error } | by(resource.service.name) | count() > 1, which instead seems correct:
Screenshot 2023-08-28 at 15 49 51

In addition, this PR also fixes a small typo (missing whitespace before a }).

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@fabrizio-grafana fabrizio-grafana self-assigned this Aug 28, 2023
@fabrizio-grafana fabrizio-grafana added this to the Next milestone Aug 28, 2023
@fabrizio-grafana fabrizio-grafana changed the title Fix invalid query Docs: Fix invalid query Aug 28, 2023
@fabrizio-grafana fabrizio-grafana marked this pull request as ready for review August 28, 2023 14:33
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! nice fix.

@joe-elliott joe-elliott merged commit a6a934f into main Aug 28, 2023
14 checks passed
@joe-elliott joe-elliott deleted the fix-invalid-query-in-docs branch August 28, 2023 15:23
@knylander-grafana knylander-grafana added type/docs Improvements or additions to documentation backport release-v2.2 labels Aug 29, 2023
@knylander-grafana
Copy link
Contributor

Thank you! Since this is wrong, I'm adding it to the backport so we can make this change live.

github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
* Fix invalid query

* Chore

(cherry picked from commit a6a934f)
knylander-grafana pushed a commit that referenced this pull request Aug 29, 2023
* Fix invalid query

* Chore

(cherry picked from commit a6a934f)

Co-authored-by: Fabrizio <135109076+fabrizio-grafana@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-v2.2 type/docs Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants