Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 429s tripping SLOs #3469

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Fix 429s tripping SLOs #3469

merged 3 commits into from
Mar 6, 2024

Conversation

joe-elliott
Copy link
Member

@joe-elliott joe-elliott commented Mar 6, 2024 •
edited
Loading

What this PR does

  • Correctly translates "queue full" into a 429 for the http pipeline
  • Correctly propagates ResourceExhausted gRPC error instead of InvalidArgument
  • Correctly prevents 429s from counting against SLOs

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

mapno
mapno approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@joe-elliott
fix 429s tripping SLOs
66b2db2 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
changelog
23973e5 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
test fix
9ad94c1 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott merged commit ae083c3 into grafana:main Mar 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapno mapno mapno approved these changes

@annanay25 annanay25 Awaiting requested review from annanay25

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-elliott @mapno