-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slo: include all request cancellations within SLO #4355
base: main
Are you sure you want to change the base?
Conversation
for case 2, I think the Handlers should pass correct error to let me update the handlers to handle these late cancellation. |
df58c34
to
f8de330
Compare
@electron0zero Adding some more thoughts about the default behavior of counting canceled requests within SLO: I think we could also support an operator that wants to exclude them from SLO by adding an additional label that indicates if the request was completed or canceled like An additional benefit is that this would give us metrics on canceled requests in general, which I don't think we have today. Could be useful. I think this should be feasible and localized to the postSLOHook method where it is checking for cancelations already. But let me know if there are considerations I missed. |
What this PR does:
We count all request cancellations outside SLO, but that's not right because request cancellations are done by users and should fall within SLO.
this PR is changing the way to count request cancellations, and now correctly counts then within SLOs.
I also made some changes to send back codes.Canceled gRPC error from collectors.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]