Rename k6 pkg to k6ext #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
rename/k6-pkg-k6ext
branch
from
7092f9e
to
93c5ac4
Compare
ankur22
approved these changes
May 30, 2022
imiric
approved these changes
May 31, 2022
Due to a bug in xk6 (grafana/xk6#45), we can't have a directory or a file with a name k6. As discussed internally, @imiric suggested renaming the k6 pkg to k6ext: "k6ext follows the k6 convention of doing the same: errext, netext, etc., so let's stick to that.".
inancgumus
force-pushed
the
rename/k6-pkg-k6ext
branch
from
93c5ac4
to
4965e2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in xk6 (grafana/xk6#45), we can't have a directory or a file with the name k6.
As discussed internally, @imiric suggested renaming the
k6pkg tok6ext:The pkg directory
k6extclashed withe2e.ymlas the E2E CI job was usingk6extas its output directory. This PR changes the output directory tok6extension.