This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Fix errors on Close and Wait when browser closes #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imiric
reviewed
Jun 28, 2022
ankur22
force-pushed
the
bug/415_close_error
branch
from
414d93b to
5222abb
Compare
imiric
reviewed
Jun 28, 2022
ankur22
added a commit
that referenced
this pull request
Jun 28, 2022
Resolves: #419 (comment) Resolves: #419 (comment)
inancgumus
approved these changes
Jun 28, 2022
imiric
reviewed
Jun 28, 2022
ankur22
added a commit
that referenced
this pull request
Jun 28, 2022
imiric
approved these changes
Jun 28, 2022
- Close on the stdout pipe is already dealt with by Wait. - Kill signal is sent when the context is closed so only log other non kill related errors. Fixes: #415 Resolves: #419 (comment) Resolves: #419 (comment) Resolves: #419 (comment) Resolves: #419 (comment)
ankur22
force-pushed
the
bug/415_close_error
branch
from
b87e971 to
5750799
Compare
ankur22
added a commit
that referenced
this pull request
Jun 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Browser process close errors when running more than 1 iteration #415