-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xk6 should not put k6 binary in the k6/k6 if k6 is a directory #3
Comments
This seems to be an issue with So I'd rather not add any workarounds for this in xk6 and wait until it's fixed upstream. Feel free to create that Go issue 😄 As for a replacement prompt, not sure if that's needed. I like the current defaults to overwrite without prompting or erroring out, it seems like less hoops to jump through during development. |
Given the docs on it
I do think this is the expected way for it. So it seems better if we check if the file we are going to write to exists and whether it's a file |
If there is a directory named k6 in the current directory, xk6 build will put the new k6 binary inside of it, instead of .. erroring out or putting in k6-extented or something like that.
Also maybe have a prompt before replacing files that is overwritten with
-y
?The text was updated successfully, but these errors were encountered: