Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune additional data from storage, add min_epochs_for_block_requests to Config #92

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Tumas
Copy link
Member

@Tumas Tumas commented Jan 20, 2025

No description provided.

@Tumas Tumas marked this pull request as draft January 20, 2025 15:04
@Tumas Tumas marked this pull request as ready for review January 20, 2025 15:06

Builder::new()
.name("old-blob-pruner".to_owned())
.name("old-record-pruner".to_owned())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Choose a shorter thread name. At least on Linux thread names have 16 byte limit1 (including terminating null byte - so that leaves 15 bytes for the name) - anything longer will be truncated.

Footnotes

  1. pthread_setname_np

@SifraiTeam SifraiTeam force-pushed the feature/prune-additional-data-from-storage branch from 6fe3b9e to 1127872 Compare January 21, 2025 12:11
@SifraiTeam SifraiTeam force-pushed the feature/prune-additional-data-from-storage branch from 1127872 to 4a8f2a6 Compare January 21, 2025 13:13
@Tumas Tumas merged commit d556ebf into develop Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants