Removing function 'send_email'

[deniszh]

It's insecure, not used in the code and undocumented.

Fixing #2008

Please also note that sending email from Dashboard is implemented in completely different commit 'e2a70d8' and not use 'send_email' function at all.

[cbowman0]

I know no reason removing this would cause a problem.

[JLLeitschuh]

You also need to remove the call to this endpoint from inside of the UI, unless that UI component uses some newer logic.

[deniszh]

You also need to remove the call to this endpoint from inside of the UI, unless that UI component uses some newer logic.

That's a point - there's no call from UI exist. Or any other call. It looks like some abandoned piece of code, which was never used.

[cbowman0]

Which UI component? I find no callers of send_email.

[DanCech]

It looks like we can also get rid of the SMTP_SERVER config setting, which isn't used anywhere else.

[deniszh]

@DanCech : well... Dashboard have ability to send email, see e2a70d8

[deniszh]

It's probably also worth to backport it to 0.9.x and 1.0.x
Not sure should we make new releases for this branches... Maybe fixed branch should be enough.

[DanCech]

Yes but that doesn't use that config setting, it uses the django EmailMessage class which is configured via the django EMAIL_* settings.

[deniszh]

Yes but that doesn't use that config setting, it uses the django EmailMessage class which is configured via the django EMAIL_* settings.

Ah, nice find then, @DanCech
Removed together with unused imports.

[codecov-io]

Codecov Report

Merging #2499 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2499      +/-   ##
==========================================
- Coverage   80.01%   79.96%   -0.05%     
==========================================
  Files          85       85              
  Lines        9131     9091      -40     
  Branches     1948     1948              
==========================================
- Hits         7306     7270      -36     
+ Misses       1544     1540       -4     
  Partials      281      281

Impacted Files	Coverage Δ
webapp/graphite/settings.py	74.75% <ø> (-0.13%)	⬇️
webapp/graphite/composer/views.py	23.8% <ø> (-31.75%)	⬇️
webapp/graphite/composer/urls.py	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021cfe6...5a5f231. Read the comment docs.

[DanCech]

Nice work!

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.96%. Comparing base (021cfe6) to head (5a5f231).
⚠️ Report is 382 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2499      +/-   ##
==========================================
- Coverage   80.01%   79.96%   -0.05%     
==========================================
  Files          85       85              
  Lines        9131     9091      -40     
  Branches     1948     1948              
==========================================
- Hits         7306     7270      -36     
+ Misses       1544     1540       -4     
  Partials      281      281              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.