diff --git a/packages/horizon/contracts/data-service/extensions/DataServiceFees.sol b/packages/horizon/contracts/data-service/extensions/DataServiceFees.sol index 25259805d..a1c38a99a 100644 --- a/packages/horizon/contracts/data-service/extensions/DataServiceFees.sol +++ b/packages/horizon/contracts/data-service/extensions/DataServiceFees.sol @@ -88,7 +88,7 @@ abstract contract DataServiceFees is DataService, DataServiceFeesV1Storage, IDat * @dev This function is used as a callback in the stake claims linked list traversal. * @param _claimId The id of the stake claim * @param _acc The accumulator for the stake claims being processed - * @return Wether the stake claim is still locked, indicating that the traversal should continue or stop. + * @return Whether the stake claim is still locked, indicating that the traversal should continue or stop. * @return The updated accumulator data */ function _processStakeClaim(bytes32 _claimId, bytes memory _acc) private returns (bool, bytes memory) { diff --git a/packages/horizon/contracts/data-service/utilities/ProvisionManager.sol b/packages/horizon/contracts/data-service/utilities/ProvisionManager.sol index b27faf1f1..699394c8d 100644 --- a/packages/horizon/contracts/data-service/utilities/ProvisionManager.sol +++ b/packages/horizon/contracts/data-service/utilities/ProvisionManager.sol @@ -153,8 +153,6 @@ abstract contract ProvisionManager is Initializable, GraphDirectory, ProvisionMa * the {HorizonStaking} contract. * @dev Checks the pending provision parameters, not the current ones. * - * Emits a {ProvisionPendingParametersAccepted} event. - * * @param _serviceProvider The address of the service provider. */ function _acceptProvisionParameters(address _serviceProvider) internal { diff --git a/packages/horizon/contracts/interfaces/IAuthorizable.sol b/packages/horizon/contracts/interfaces/IAuthorizable.sol index 1ba46341c..cd6553fa7 100644 --- a/packages/horizon/contracts/interfaces/IAuthorizable.sol +++ b/packages/horizon/contracts/interfaces/IAuthorizable.sol @@ -100,7 +100,7 @@ interface IAuthorizable { * - `proof` must be a valid signature from the signer being authorized * * Emits a {SignerAuthorized} event - * @param signer The addres of the signer + * @param signer The address of the signer * @param proofDeadline The deadline for the proof provided by the signer * @param proof The proof provided by the signer to be authorized by the authorizer * consists of (chain id, verifying contract address, domain, proof deadline, authorizer address) @@ -141,7 +141,8 @@ interface IAuthorizable { function revokeAuthorizedSigner(address signer) external; /** - * @notice Returns the timestamp at which the thawing period ends for a signer + * @notice Returns the timestamp at which the thawing period ends for a signer. + * Returns 0 if the signer is not thawing. * @param signer The address of the signer * @return The timestamp at which the thawing period ends */ diff --git a/packages/horizon/contracts/interfaces/internal/IHorizonStakingMain.sol b/packages/horizon/contracts/interfaces/internal/IHorizonStakingMain.sol index 2fb930903..71cf7b3b4 100644 --- a/packages/horizon/contracts/interfaces/internal/IHorizonStakingMain.sol +++ b/packages/horizon/contracts/interfaces/internal/IHorizonStakingMain.sol @@ -24,7 +24,7 @@ interface IHorizonStakingMain { /** * @notice Emitted when a service provider unstakes tokens during the transition period. * @param serviceProvider The address of the service provider - * @param tokens The amount of tokens unstaked + * @param tokens The amount of tokens now locked (including previously locked tokens) * @param until The block number until the stake is locked */ event HorizonStakeLocked(address indexed serviceProvider, uint256 tokens, uint256 until); diff --git a/packages/horizon/contracts/libraries/MathUtils.sol b/packages/horizon/contracts/libraries/MathUtils.sol index 7b023e556..fc81e9608 100644 --- a/packages/horizon/contracts/libraries/MathUtils.sol +++ b/packages/horizon/contracts/libraries/MathUtils.sol @@ -13,7 +13,7 @@ library MathUtils { * @dev Calculates the weighted average of two values pondering each of these * values based on configured weights. The contribution of each value N is * weightN/(weightA + weightB). The calculation rounds up to ensure the result - * is always greater than the smallest of the two values. + * is always equal or greater than the smallest of the two values. * @param valueA The amount for value A * @param weightA The weight to use for value A * @param valueB The amount for value B diff --git a/packages/horizon/contracts/payments/collectors/GraphTallyCollector.sol b/packages/horizon/contracts/payments/collectors/GraphTallyCollector.sol index b8e724f2a..c3009f41a 100644 --- a/packages/horizon/contracts/payments/collectors/GraphTallyCollector.sol +++ b/packages/horizon/contracts/payments/collectors/GraphTallyCollector.sol @@ -88,7 +88,7 @@ contract GraphTallyCollector is EIP712, GraphDirectory, Authorizable, IGraphTall * This variant adds the ability to partially collect a RAV by specifying the amount of tokens to collect. * @param _paymentType The payment type to collect * @param _data Additional data required for the payment collection - * @param _tokensToCollect The amount of tokens to collect + * @param _tokensToCollect The amount of tokens to collect. If 0, all tokens from the RAV will be collected. * @return The amount of tokens collected */ function _collect( diff --git a/packages/subgraph-service/contracts/DisputeManager.sol b/packages/subgraph-service/contracts/DisputeManager.sol index 25b37e41b..0771580f0 100644 --- a/packages/subgraph-service/contracts/DisputeManager.sol +++ b/packages/subgraph-service/contracts/DisputeManager.sol @@ -413,7 +413,7 @@ contract DisputeManager is ) ); - // Only one dispute for a (indexer, subgraphDeploymentId) at a time + // Only one dispute at a time require(!isDisputeCreated(disputeId), DisputeManagerDisputeAlreadyCreated(disputeId)); // Store dispute