Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor subgraph store tests #3662

Merged
merged 5 commits into from
Aug 1, 2022
Merged

Refactor subgraph store tests #3662

merged 5 commits into from
Aug 1, 2022

Conversation

evaporei
Copy link
Contributor

@evaporei evaporei commented Jun 13, 2022 •
edited
Loading

Fixes: #3663

@evaporei evaporei requested a review from leoyvens June 13, 2022 22:15
@evaporei evaporei self-assigned this Jun 13, 2022
@leoyvens leoyvens mentioned this pull request Jun 21, 2022
Closed
leoyvens
leoyvens requested changes Jul 29, 2022
View reviewed changes
store/postgres/src/deployment.rs Outdated Show resolved Hide resolved
@evaporei evaporei changed the title graphql: Make StoreResolver::at_block only return indexing_error if non-fatal-errors is enabled Refactor subgraph store tests Jul 29, 2022
@evaporei evaporei requested a review from leoyvens July 29, 2022 16:20
@evaporei
Copy link
Contributor Author

I've removed the wrong behavior, now all commits are refactor/renaming wise 🙂

leoyvens
leoyvens requested changes Aug 1, 2022
View reviewed changes
store/postgres/src/query_store.rs Outdated Show resolved Hide resolved
@evaporei evaporei merged commit 91a2034 into master Aug 1, 2022
@evaporei evaporei deleted the eva/fix-non-fatal-errors branch August 1, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoyvens leoyvens leoyvens approved these changes

Assignees

@evaporei evaporei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphQL: indexing_error should only be returned if the subgraph has non-fatal errors feature enabled
2 participants
@evaporei @leoyvens