refactor: change gateway to router, install.sh script
#368
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @dotansimha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request implements a significant refactoring to standardize the naming of the core application from "gateway" to "router" throughout the project. This change aims to align the project's terminology with its evolving purpose and improve clarity. In addition to the widespread renaming, a new installation script has been introduced to streamline the setup process for users.
Highlights
- Core Application Renaming: The primary application has been comprehensively renamed from "gateway" to "router" across the entire codebase, including binary names, package names, and internal references.
- New Installation Script: A new
install.shscript has been introduced to simplify the process of downloading and installing therouterbinary directly from GitHub releases, supporting Linux AMD64 and ARM64 architectures. - Configuration and Documentation Updates: All related configuration files, build scripts, Dockerfiles, and user-facing documentation (like READMEs and profiling guides) have been updated to reflect the new "router" terminology and remove outdated "gateway" references.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request is a significant refactoring that renames the project from gateway to router. The changes are extensive, touching many files, but they appear to be consistently applied throughout the codebase. Additionally, a new install.sh script has been added to facilitate binary installation. I've found a couple of issues: one in the new install.sh script that would prevent it from working, and another in the new Dockerfile which contains a misleading command.
|
🐋 This PR was built and pushed to the following Docker images: Image Names: Platforms: Image Tags: Docker metadata{
"buildx.build.ref": "builder-2f0d26bb-ad0f-4042-9477-6f359e480814/builder-2f0d26bb-ad0f-4042-9477-6f359e4808140/smbevqmc9twzo4gxbcbzsci5i",
"containerimage.descriptor": {
"mediaType": "application/vnd.oci.image.index.v1+json",
"digest": "sha256:ee71aa0baf187c05830501f09a261d915315c2f6f23c9f5393cd92d0e4a725c3",
"size": 1609
},
"containerimage.digest": "sha256:ee71aa0baf187c05830501f09a261d915315c2f6f23c9f5393cd92d0e4a725c3",
"image.name": "ghcr.io/graphql-hive/router:pr-368,ghcr.io/graphql-hive/router:sha-5353c16"
} |
✅
|
1 participant
TODO
install.shgatewaytorouterCloses #366
Closes #362