[ESLint] replace .forEach with for..of (#3113)

graphql · Apr 14, 2023 · 2e477eb · 2e477eb
1 parent a8f21ad
commit 2e477eb
Show file tree

Hide file tree

Showing 26 changed files with 148 additions and 123 deletions.
diff --git a/.changeset/breezy-laws-sneeze.md b/.changeset/breezy-laws-sneeze.md
@@ -0,0 +1,12 @@
+---
+'codemirror-graphql': patch
+'graphiql': patch
+'@graphiql/react': patch
+'@graphiql/toolkit': patch
+'graphql-language-service': patch
+'graphql-language-service-server': patch
+'monaco-graphql': patch
+'vscode-graphql-execution': patch
+---
+
+replace `.forEach` with `for..of`
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -268,6 +268,7 @@ module.exports = {
     'unicorn/prefer-export-from': ['error', { ignoreUsedVariables: true }],
     'unicorn/throw-new-error': 'error',
     'unicorn/prefer-includes': 'error',
+    'unicorn/no-array-for-each': 'error',
     'no-lonely-if': 'error',
     'unicorn/no-lonely-if': 'error',
     'unicorn/prefer-optional-catch-binding': 'error',

diff --git a/examples/monaco-graphql-webpack/src/index.ts b/examples/monaco-graphql-webpack/src/index.ts
@@ -256,15 +256,15 @@ function getSchemaPicker(): HTMLSelectElement {
   const schemaPicker = document.createElement('select');
   schemaPicker.id = 'schema-picker';
 
-  schemaOptions.forEach(option => {
+  for (const option of schemaOptions) {
     const optEl = document.createElement('option');
     optEl.value = option.value;
     optEl.label = option.label;
     if (option.default) {
       optEl.selected = true;
     }
     schemaPicker.appendChild(optEl);
-  });
+  }
 
   return schemaPicker;
 }

diff --git a/packages/codemirror-graphql/src/utils/collectVariables.ts b/packages/codemirror-graphql/src/utils/collectVariables.ts
@@ -22,18 +22,18 @@ export default function collectVariables(
   documentAST: DocumentNode,
 ) {
   const variableToType = Object.create(null);
-  documentAST.definitions.forEach(definition => {
+  for (const definition of documentAST.definitions) {
     if (definition.kind === 'OperationDefinition') {
       const { variableDefinitions } = definition;
       if (variableDefinitions) {
-        variableDefinitions.forEach(({ variable, type }) => {
+        for (const { variable, type } of variableDefinitions) {
           const inputType = typeFromAST(schema, type as NamedTypeNode);
           if (inputType) {
             variableToType[variable.name.value] = inputType;
           }
-        });
+        }
       }
     }
-  });
+  }
   return variableToType;
 }
diff --git a/packages/codemirror-graphql/src/utils/runParser.ts b/packages/codemirror-graphql/src/utils/runParser.ts
@@ -23,11 +23,11 @@ export default function runParser(
   const state = parser.startState();
   const lines = sourceText.split('\n');
 
-  lines.forEach(line => {
+  for (const line of lines) {
     const stream = new CharacterStream(line);
     while (!stream.eol()) {
       const style = parser.token(stream, state);
       callbackFn(stream, state, style);
     }
-  });
+  }
 }
diff --git a/packages/codemirror-graphql/src/variables/lint.ts b/packages/codemirror-graphql/src/variables/lint.ts
@@ -85,14 +85,14 @@ function validateVariables(
 ) {
   const errors: CodeMirror.Annotation[] = [];
 
-  variablesAST.members.forEach(member => {
+  for (const member of variablesAST.members) {
     if (member) {
       const variableName = member.key?.value;
       const type = variableToType[variableName];
       if (type) {
-        validateValue(type, member.value).forEach(([node, message]) => {
+        for (const [node, message] of validateValue(type, member.value)) {
           errors.push(lintError(editor, node, message));
-        });
+        }
       } else {
         errors.push(
           lintError(
@@ -103,7 +103,7 @@ function validateVariables(
         );
       }
     }
-  });
+  }
 
   return errors;
 }
@@ -169,7 +169,7 @@ function validateValue(
     );
 
     // Look for missing non-nullable fields.
-    Object.keys(type.getFields()).forEach(fieldName => {
+    for (const fieldName of Object.keys(type.getFields())) {
       const field = type.getFields()[fieldName];
       if (
         !providedFields[fieldName] &&
@@ -181,7 +181,7 @@ function validateValue(
           `Object of type "${type}" is missing required field "${fieldName}".`,
         ]);
       }
-    });
+    }
 
     return fieldErrors;
   }

diff --git a/packages/graphiql-react/src/editor/hooks.ts b/packages/graphiql-react/src/editor/hooks.ts
@@ -314,13 +314,17 @@ export function useAutoCompleteLeafs({
             },
           ),
         );
-        setTimeout(() => markers.forEach(marker => marker.clear()), 7000);
+        setTimeout(() => {
+          for (const marker of markers) {
+            marker.clear();
+          }
+        }, 7000);
         let newCursorIndex = cursorIndex;
-        insertions.forEach(({ index, string }) => {
+        for (const { index, string } of insertions) {
           if (index < cursorIndex) {
             newCursorIndex += string.length;
           }
-        });
+        }
         queryEditor.setCursor(queryEditor.posFromIndex(newCursorIndex));
       });
     }

diff --git a/packages/graphiql-toolkit/src/graphql-helpers/auto-complete.ts b/packages/graphiql-toolkit/src/graphql-helpers/auto-complete.ts
@@ -109,11 +109,11 @@ function defaultGetDefaultFieldNames(type: GraphQLType) {
 
   // Include all leaf-type fields.
   const leafFieldNames: Array<string> = [];
-  Object.keys(fields).forEach(fieldName => {
+  for (const fieldName of Object.keys(fields)) {
     if (isLeafType(fields[fieldName].type)) {
       leafFieldNames.push(fieldName);
     }
-  });
+  }
   return leafFieldNames;
 }
 
@@ -174,10 +174,10 @@ function withInsertions(initial: string, insertions: Insertion[]) {
   }
   let edited = '';
   let prevIndex = 0;
-  insertions.forEach(({ index, string }) => {
+  for (const { index, string } of insertions) {
     edited += initial.slice(prevIndex, index) + string;
     prevIndex = index;
-  });
+  }
   edited += initial.slice(prevIndex);
   return edited;
 }

diff --git a/packages/graphiql/cypress/e2e/init.cy.ts b/packages/graphiql/cypress/e2e/init.cy.ts
@@ -38,7 +38,9 @@ describe('GraphiQL On Initialization', () => {
     ];
     cy.visit(`/`);
     cy.get('.graphiql-query-editor').contains('# Welcome to GraphiQL');
-    containers.forEach(cSelector => cy.get(cSelector).should('be.visible'));
+    for (const cSelector of containers) {
+      cy.get(cSelector).should('be.visible');
+    }
   });
 
   it('Executes a GraphQL query over HTTP that has the expected result', () => {

diff --git a/packages/graphiql/resources/renderExample.js b/packages/graphiql/resources/renderExample.js
@@ -14,17 +14,14 @@
 
 // Parse the search string to get url parameters.
 var parameters = {};
-window.location.search
-  .slice(1)
-  .split('&')
-  .forEach(function (entry) {
-    var eq = entry.indexOf('=');
-    if (eq >= 0) {
-      parameters[decodeURIComponent(entry.slice(0, eq))] = decodeURIComponent(
-        entry.slice(eq + 1),
-      );
-    }
-  });
+for (const entry of window.location.search.slice(1).split('&')) {
+  var eq = entry.indexOf('=');
+  if (eq >= 0) {
+    parameters[decodeURIComponent(entry.slice(0, eq))] = decodeURIComponent(
+      entry.slice(eq + 1),
+    );
+  }
+}
 
 // When the query and variables string is edited, update the URL bar so
 // that it can be easily shared.