-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode-graphql, LSP, IDE initiative #1615
Comments
@acao is there a way we can implement We already have a lot of validation rules here, we just need to extract them on a generic way. I'm a nvim user and I created coc-graphql a few weeks ago. CoC plugins have basically the same config as any other vscode plugin, it shouldn't be hard to reuse the same code on both plugins. |
@felippepuhle awesome! very excited about coc-graphql. i just cut an alpha of the lsp server last night that should be quite an enhancement!
graphiql/packages/graphql-language-service-interface/src/GraphQLLanguageService.ts Line 198 in 7dfaef7
previously, it would load from a specified file path, but in graphql-config@3 we support commonjs. so now you can require() a file that provides an array of custom rules, or you can define them implicitly in the graphql.config.js file, your choice! |
That's awesome! I'll take a look ASAP, thanks! |
@tvvignesh this is possible now that i've squashed some bugs i introduced during this initiative! |
the follow up! |
Getting things in better shape for
vscode-graphql
which I am now maintainer of!graphql-language-service-interface
graphq-config@3.0.x
- schema loading, file loading, etcgetAutocompleteSuggestions
codemirror-graphql
, etc)getOutline
for workspacesgetDefinition
for workspaces{}
monoco
/vscode-languageserver
)monaco
orvscode-languageserver
)graphql-language-service-server
graphql
initialization
and on each relevant workspace folder/file event, or at least cache all definitions ononRequestWorkspaceSymbol
. useinvalidateCache()
RequestWorkspaceDefinition
event similarlyvscode-graphql
is becoming our go-to reference implementation, and this work is towards 3.x.x releases:
vscode-graphql@3.0.0
external issues:
graphql-config
endpoints extension no longer supportsenv
, so we still have to figure out how to replace use ofenv
The text was updated successfully, but these errors were encountered: