Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode-graphql-syntax] (v1.2.3) triple double-quote comment syntax broken for TypeScript #3515

Closed
TiE23 opened this issue Jan 25, 2024 · 4 comments · Fixed by #3529
Closed

Comments

@TiE23
Copy link

TiE23 commented Jan 25, 2024

With v1.2.3 (possibly originating in #3490, though I am not certain) support for triple double-quote comments, which are used to generate doc comments for the schema (whether it's a built-in feature for Prisma or an undocumented feature for graphql-codegen I'm not sure).

Behavior in v1.2.2

Screenshot 2024-01-25 at 12 33 34 AM

Behavior in v1.2.3

Screenshot 2024-01-25 at 12 32 57 AM

It appears that if the """ comment is placed inside a curly brace, it works fine. But in the root scope (?), it appears to break.

How this is useful to me:
image

image

Current work-around is to install v1.2.2
image

@acao
Copy link
Member

acao commented Jan 25, 2024

ah yes, it appears to be this:

https://github.com/graphql/graphiql/pull/3490/files#diff-89a0bf9dd1dfa9498b6e3f566257d012e1bfff0cb6b663735aac011eaae74dbcR50

which was introduced to fix inline double quote queries like graphql("#query { id }")

can you open a PR that adds this failing case to the test suite? I can take a look after work today

@TiE23
Copy link
Author

TiE23 commented Jan 25, 2024

I hope this is what you needed!

@acao
Copy link
Member

acao commented Feb 3, 2024

@TiE23 thank you! I will finish fixing this for now, there is another huge PR someone has proposed for the textmate grammars which does not solve this problem, so I will solve this one first!

@acao
Copy link
Member

acao commented Feb 4, 2024

1.3.2 will be your fix version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants