Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move vscode grammars, basic language support to standalone syntax extension #2573

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

acao
Copy link
Member

@acao acao commented Jul 16, 2022

vscode-graphql now depends on this extension, and provides language server support in addition. this allows alternative LSP servers and non-LSP graphql extensions to use our highlighting only, or allows users to just install the syntax highlighting extension if they don't need LSP server features.

@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2022

🦋 Changeset detected

Latest commit: 821c189

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
vscode-graphql Minor
vscode-graphql-syntax Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

| Package | Version |
|------|---------|
yarn workspace  | graphiql/react
| > vscode-graphql | 0.7.0-canary-fd0bb656.0

@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #2573 (821c189) into main (2d91916) will increase coverage by 3.90%.
The diff coverage is 23.84%.

@@            Coverage Diff             @@
##             main    #2573      +/-   ##
==========================================
+ Coverage   65.70%   69.61%   +3.90%     
==========================================
  Files          85       72      -13     
  Lines        5106     4275     -831     
  Branches     1631     1436     -195     
==========================================
- Hits         3355     2976     -379     
+ Misses       1747     1294     -453     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.66% <5.66%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 47.61% <66.66%> (+0.63%) ⬆️
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5827977...821c189. Read the comment docs.

@acao
Copy link
Member Author

acao commented Jul 24, 2022

CC @captbaritone @orta this is the PR for creating the syntax only extension by the way!

I think I can finish setting this up today. i think we will use the namespace GraphQL.vscode-graphql-syntax because the naming convention then reflects that it is related to this project, so it might help users with navigation who have an issue with that extension vs yours or others. however GraphQL.syntax is very tempting haha

…syntax extension.

`vscode-graphql` now depends on this extension, and provides language server support in addition. this allows alternative LSP servers and non-LSP graphql extensions to use our highlighting only, or allows users to just install the syntax highlighting extension if they don't need LSP server features.
@acao acao force-pushed the syntax-only-extension branch from 95a578d to 22a3c10 Compare July 30, 2022 17:16
@acao acao force-pushed the syntax-only-extension branch from e9e7622 to 73f4fee Compare July 30, 2022 18:20
@acao acao changed the title move vscode grammars, basic language support & snippets to syntax extension move vscode grammars, basic language support & snippets to standalone syntax extension Jul 30, 2022
@acao acao changed the title move vscode grammars, basic language support & snippets to standalone syntax extension move vscode grammars, basic language support to standalone syntax extension Jul 30, 2022
@acao acao merged commit a358ac1 into main Aug 1, 2022
@acao acao deleted the syntax-only-extension branch August 1, 2022 07:19
@acao acao mentioned this pull request Aug 1, 2022
@acao
Copy link
Member Author

acao commented Aug 1, 2022

Just thought that the @graphql/tsc might like to know this really exciting change happened today, as well as this related one for relay:

facebook/relay#4032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant