Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export constants MAX_INT and MIN_INT #2582

Closed
wants to merge 3 commits into from
Closed

export constants MAX_INT and MIN_INT #2582

wants to merge 3 commits into from

Conversation

overhead525
Copy link

Resolving issue #2524

@danielrearden
Copy link
Contributor

@overhead525 Thanks for your PR!

It looks like your changes inadvertently also changed some of the existing formatting, which is causing this PR to fail the formatting check. The two constants should also be added as exports to scalars.d.ts (i.e. export declare const MAX_INT: number;) to keep the TypeScript type declarations inline with the Flow ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants