Skip to content

upgrade dependencies #4459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2025
Merged

upgrade dependencies #4459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66c4a33
upgrade dependencies
yaacovCR Jul 16, 2025
870c942
replace with hand-crafted async generator for node v20
yaacovCR Jul 16, 2025
e04ea6d
fix for node v20
yaacovCR Jul 16, 2025
53c3c84
add comments for when to remove fetch and fs.cpSync from n/no-unsuppo…
yaacovCR Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 23 additions & 35 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export default tsConfig(
'internal-rules/require-to-string-tag': 'off',

//////////////////////////////////////////////////////////////////////////////
// `eslint-plugin-n` rule list based on `v17.14.x`
// `eslint-plugin-n` rule list based on `v17.21.x`
//////////////////////////////////////////////////////////////////////////////

// Rules
Expand All @@ -82,6 +82,7 @@ export default tsConfig(
'n/no-restricted-import': 'off',
'n/no-restricted-require': 'off',
'n/no-sync': 'off', // TODO: consider enabling, currently triggers with executeSync/graphqlSync, without ability to add exceptions
'n/no-top-level-await': 'error',
'n/no-unpublished-bin': 'error',
'n/no-unpublished-import': 'error',
'n/no-unpublished-require': 'error',
Expand All @@ -105,12 +106,13 @@ export default tsConfig(
'n/shebang': 'error',

//////////////////////////////////////////////////////////////////////////////
// `eslint-plugin-import` rule list based on `v2.31.x`
// `eslint-plugin-import` rule list based on `v2.32.x`
//////////////////////////////////////////////////////////////////////////////

// Static analysis
// https://github.com/benmosher/eslint-plugin-import#static-analysis
'import/default': 'error',
'import/enforce-node-protocol-usage': ['error', 'always'],
'import/named': 'error',
'import/namespace': 'error',
'import/no-absolute-path': 'error',
Expand Down Expand Up @@ -228,7 +230,7 @@ export default tsConfig(
'simple-import-sort/exports': 'off', // TODO: error

//////////////////////////////////////////////////////////////////////////////
// ESLint builtin rules list based on `v9.16.x`
// ESLint builtin rules list based on `v9.31.x`
//////////////////////////////////////////////////////////////////////////////

// Possible Errors
Expand Down Expand Up @@ -275,6 +277,7 @@ export default tsConfig(
'no-sparse-arrays': 'error',
'no-template-curly-in-string': 'error',
'no-this-before-super': 'error',
'no-unassigned-vars': 'error',
'no-undef': 'error',
'no-unexpected-multiline': 'error',
'no-unmodified-loop-condition': 'error',
Expand Down Expand Up @@ -492,7 +495,7 @@ export default tsConfig(
},
rules: {
//////////////////////////////////////////////////////////////////////////
// `@typescript-eslint/eslint-plugin` rule list based on `v8.16.x`
// `@typescript-eslint/eslint-plugin` rule list based on `v8.37.x`
//////////////////////////////////////////////////////////////////////////

// Supported Rules
Expand All @@ -513,7 +516,7 @@ export default tsConfig(
],
'@typescript-eslint/ban-tslint-comment': 'error',
'@typescript-eslint/class-literal-property-style': 'off', // TODO: enable after TS conversion
'@typescript-eslint/class-methods-use-this': 'off',
'@typescript-eslint/class-methods-use-this': 'off', // now in core
'@typescript-eslint/consistent-generic-constructors': 'error',
'@typescript-eslint/consistent-indexed-object-style': [
'error',
Expand All @@ -524,32 +527,27 @@ export default tsConfig(
'@typescript-eslint/consistent-type-definitions': 'error',
'@typescript-eslint/consistent-type-exports': 'error',
'@typescript-eslint/consistent-type-imports': 'error',
'@typescript-eslint/default-param-last': 'error',
'@typescript-eslint/default-param-last': 'off', // now in core
'@typescript-eslint/dot-notation': 'error',
'@typescript-eslint/explicit-function-return-type': 'off', // TODO: consider
'@typescript-eslint/explicit-member-accessibility': 'off', // TODO: consider
'@typescript-eslint/explicit-module-boundary-types': 'off', // TODO: consider
'@typescript-eslint/init-declarations': 'off',
'@typescript-eslint/max-params': [
'error',
{
max: 5, // TODO: drop to default number, which is 3
},
],
'@typescript-eslint/init-declarations': 'off', // now in core
'@typescript-eslint/max-params': 'off', // now in core
'@typescript-eslint/member-ordering': 'error',
'@typescript-eslint/method-signature-style': 'error',
'@typescript-eslint/naming-convention': 'off',
'@typescript-eslint/no-array-constructor': 'error',
'@typescript-eslint/no-array-constructor': 'off', // now in core
'@typescript-eslint/no-array-delete': 'error',
'@typescript-eslint/no-base-to-string': 'error',
'@typescript-eslint/no-confusing-non-null-assertion': 'error',
'@typescript-eslint/no-confusing-void-expression': 'off', // TODO: enable with ignoreArrowShorthand
'@typescript-eslint/no-deprecated': 'off',
'@typescript-eslint/no-dupe-class-members': 'error',
'@typescript-eslint/no-dupe-class-members': 'off', // now in core
'@typescript-eslint/no-duplicate-enum-values': 'error',
'@typescript-eslint/no-duplicate-type-constituents': 'error',
'@typescript-eslint/no-dynamic-delete': 'off',
'@typescript-eslint/no-empty-function': 'error',
'@typescript-eslint/no-empty-function': 'off', // now in core
'@typescript-eslint/no-empty-object-type': 'error',
'@typescript-eslint/no-explicit-any': 'off', // TODO: error
'@typescript-eslint/no-extra-non-null-assertion': 'error',
Expand All @@ -565,10 +563,10 @@ export default tsConfig(
ignoreProperties: true,
},
],
'@typescript-eslint/no-invalid-this': 'error',
'@typescript-eslint/no-invalid-this': 'off', // now in core
'@typescript-eslint/no-invalid-void-type': 'error',
'@typescript-eslint/no-loop-func': 'error',
'@typescript-eslint/no-magic-numbers': 'off',
'@typescript-eslint/no-magic-numbers': 'off', // now in core
'@typescript-eslint/no-meaningless-void-operator': 'error',
'@typescript-eslint/no-misused-new': 'error',
'@typescript-eslint/no-misused-promises': 'error',
Expand All @@ -582,7 +580,7 @@ export default tsConfig(
'@typescript-eslint/no-require-imports': 'error',
'@typescript-eslint/no-restricted-imports': 'error',
'@typescript-eslint/no-restricted-types': 'error',
'@typescript-eslint/no-shadow': 'error',
'@typescript-eslint/no-shadow': 'off', // now in core
'@typescript-eslint/no-this-alias': 'error',
'@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
'@typescript-eslint/no-unnecessary-condition': 'off', // TODO: temporary disable
Expand All @@ -604,7 +602,7 @@ export default tsConfig(
'@typescript-eslint/no-unsafe-return': 'off', // TODO: consider
'@typescript-eslint/no-unsafe-type-assertion': 'off', // TODO: consider
'@typescript-eslint/no-unsafe-unary-minus': 'error',
'@typescript-eslint/no-unused-expressions': 'error',
'@typescript-eslint/no-unused-expressions': 'off', // now in core
'@typescript-eslint/no-unused-vars': [
'error',
{
Expand All @@ -617,8 +615,8 @@ export default tsConfig(
ignoreRestSiblings: true,
},
],
'@typescript-eslint/no-use-before-define': 'off',
'@typescript-eslint/no-useless-constructor': 'error',
'@typescript-eslint/no-use-before-define': 'off', // now in core
'@typescript-eslint/no-useless-constructor': 'off', // now in core
'@typescript-eslint/no-useless-empty-export': 'error',
'@typescript-eslint/no-wrapper-object-types': 'error',
'@typescript-eslint/non-nullable-type-assertion-style': 'off', //TODO: temporarily disabled
Expand Down Expand Up @@ -672,26 +670,13 @@ export default tsConfig(

// Below list intentionally includes ESLint rules disabled above.
// If any of the above rules are enabled in the future, they must still be disabled for TS files.
'class-methods-use-this': 'off',
'consistent-return': 'off',
'default-param-last': 'off',
'dot-notation': 'off',
'init-declarations': 'off',
'max-params': 'off',
'no-array-constructor': 'off',
'no-dupe-class-members': 'off',
'no-empty-function': 'off',
'no-implied-eval': 'off',
'no-invalid-this': 'off',
'no-loop-func': 'off',
'no-magic-numbers': 'off',
'no-redeclare': 'off',
'no-restricted-imports': 'off',
'no-shadow': 'off',
'no-unused-expressions': 'off',
'no-unused-vars': 'off',
'no-use-before-define': 'off',
'no-useless-constructor': 'off',
'only-throw-error': 'off',
'prefer-destructuring': 'off',
'prefer-promise-reject-errors': 'off',
Expand Down Expand Up @@ -816,7 +801,10 @@ export default tsConfig(
allowEmoji: true,
},
],
'n/no-top-level-await': 'off',
// TODO: remove when fetch/cpSync stabilizes across all node versions
// fetch is not supported until Node.js 21.0.0
// fs.cpSync is not supported until Node.js 22.3.0
'n/no-unsupported-features/node-builtins': [
'error',
{
Expand Down
7 changes: 5 additions & 2 deletions integrationTests/ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,16 @@
"dependencies": {
"graphql": "file:../graphql.tgz",
"graphql-esm": "file:../graphql-esm.tgz",
"@types/node": "~24.0.10",
"@types/node": "~24.0.14",
"typescript-4.9": "npm:typescript@4.9.x",
"typescript-5.0": "npm:typescript@5.0.x",
"typescript-5.1": "npm:typescript@5.1.x",
"typescript-5.2": "npm:typescript@5.2.x",
"typescript-5.3": "npm:typescript@5.3.x",
"typescript-5.4": "npm:typescript@5.4.x",
"typescript-5.5": "npm:typescript@5.5.x"
"typescript-5.5": "npm:typescript@5.5.x",
"typescript-5.6": "npm:typescript@5.6.x",
"typescript-5.7": "npm:typescript@5.7.x",
"typescript-5.8": "npm:typescript@5.8.x"
}
}
Loading
Loading