Released v1.2

[schickling]

Changes:

• Released Feature go to definition SDL - input, enum, type #237, Improve diagnostics tests #236, Fix build: bump prettier #235, fix: add ExecutableDefinitions to ignored rules for validation #234
• Updated graphql-config to 2.0.1
• Added graphql ^0.13.0 as peer dep

[lostplan]

I just want to check… this is just reflecting the changes that are published to npm?

[schickling]

Yes. Merging this synchronizes the repo with the state on NPM.

[lostplan]

👍

[IvanGoncharov]

Yes. Merging this synchronizes the repo with the state on NPM.

@schickling @lostplan Having difference beetween master and NPM worries me a lot.
Can you please setup NPM publishing on Travis simular to other graphql/* projects. For example:
https://github.com/graphql/graphql-js/blob/ae23c901c5699287c3e870a6fc7d6180049a8eb9/.travis.yml#L41-L48

[lostplan]

The (manual) lerna publish should update the version numbers, publish to npm, and push to master.

@schickling you can publish to npm but don't have collaborator status on the repo?

[IvanGoncharov]

The (manual) lerna publish should update the version numbers, publish to npm, and push to master.

But you can't create PRs for new releases and that means you can't publish new releases without NPM rights.

So this problem would not exist in a first place if @schickling had an ability to create such PR and have NPM package published after it was merged.

Just sharing my experience with graphql-js, express-graphql, graphql-swapi in all those repos I can do releases without having NPM rights just by committing to master. Plus having releases as PRs is very helpful in preventing incorrect releases, e.g. graphql/graphql-js#1346

[IvanGoncharov]

@schickling You forgot update graphql-language-service-parser it still 1.1.0
https://www.npmjs.com/package/graphql-language-service-parser

That forces me to have two different versions of graphql-config:

$ npm ls graphql-config
dd@1.0.0 /Users/ivang/dev/test
└─┬ graphql-language-service@1.2.0
  ├── graphql-config@2.0.1
  ├─┬ graphql-language-service-interface@1.2.0
  │ ├── graphql-config@2.0.1  deduped
  │ ├─┬ graphql-language-service-parser@1.1.0
  │ │ └── graphql-config@1.1.4
  │ └─┬ graphql-language-service-types@1.2.1
  │   └── graphql-config@2.0.1  deduped
  ├─┬ graphql-language-service-server@1.2.0
  │ └── graphql-config@2.0.1  deduped
  └─┬ graphql-language-service-utils@1.2.1
    └── graphql-config@2.0.1  deduped

[IvanGoncharov]

@lostplan Don't want to be paranoid but I don't know who else has or will have rights to publish on NPM. By having Travis publishing releases I can be sure that package contains the exact same code as master.