From e9a7449c64408b7fe4dacbd437440477e329e498 Mon Sep 17 00:00:00 2001
From: Russell Jones <russell.valerius.jones@gmail.com>
Date: Thu, 7 Jun 2018 23:12:11 +0000
Subject: [PATCH] Return trace.AlreadyExists along with force to allow commands
 like "tctl create -f trustedcluster.yaml" to work.

---
 lib/services/trustedcluster.go       |  4 ++--
 tool/tctl/common/resource_command.go | 28 ++++++++++++++++++++++------
 2 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/lib/services/trustedcluster.go b/lib/services/trustedcluster.go
index 1a613d4084e92..e856581eb481e 100644
--- a/lib/services/trustedcluster.go
+++ b/lib/services/trustedcluster.go
@@ -391,9 +391,9 @@ func (c *TrustedClusterV2) CanChangeStateTo(t TrustedCluster) error {
 
 	if c.GetEnabled() == t.GetEnabled() {
 		if t.GetEnabled() == true {
-			return trace.BadParameter("trusted cluster is already enabled")
+			return trace.AlreadyExists("trusted cluster is already enabled")
 		}
-		return trace.BadParameter("trusted cluster state is already disabled")
+		return trace.AlreadyExists("trusted cluster state is already disabled")
 	}
 
 	return nil
diff --git a/tool/tctl/common/resource_command.go b/tool/tctl/common/resource_command.go
index d191deef15760..5ff35aa077746 100644
--- a/tool/tctl/common/resource_command.go
+++ b/tool/tctl/common/resource_command.go
@@ -196,12 +196,20 @@ func (u *ResourceCommand) createTrustedCluster(client auth.ClientI, raw services
 
 	out, err := client.UpsertTrustedCluster(tc)
 	if err != nil {
-		return trace.Wrap(err)
+		// If force is used and UpsertTrustedCluster returns trace.AlreadyExists,
+		// this means the user tried to upsert a cluster whose exact match already
+		// exists in the backend, nothing needs to occur other than happy message
+		// that the trusted cluster has been created.
+		if u.force && trace.IsAlreadyExists(err) {
+			out = tc
+		} else {
+			return trace.Wrap(err)
+		}
 	}
 	if out.GetName() != tc.GetName() {
 		fmt.Printf("WARNING: trusted cluster %q resource has been renamed to match remote cluster name %q\n", name, out.GetName())
 	}
-	fmt.Printf("trusted cluster %q has been %v\n", out.GetName(), UpsertVerb(exists))
+	fmt.Printf("trusted cluster %q has been %v\n", out.GetName(), UpsertVerb(exists, u.force))
 	return nil
 }
 
@@ -224,7 +232,7 @@ func (u *ResourceCommand) createGithubConnector(client auth.ClientI, raw service
 		return trace.Wrap(err)
 	}
 	fmt.Printf("github connector %q has been %s\n",
-		connector.GetName(), UpsertVerb(exists))
+		connector.GetName(), UpsertVerb(exists, u.force))
 	return nil
 }
 
@@ -433,10 +441,18 @@ const (
 	formatJSON = "json"
 )
 
-func UpsertVerb(exists bool) string {
-	if exists {
+func UpsertVerb(exists bool, force bool) string {
+	switch {
+	case exists == true && force == true:
+		return "created"
+	case exists == false && force == true:
+		return "created"
+	case exists == true && force == false:
 		return "updated"
-	} else {
+	case exists == false && force == false:
 		return "created"
 	}
+
+	// Can never reach here, but the compiler complains.
+	return "unknown"
 }