From 82d2ea0f7ca6eff1968be12957cef1e9873dd4c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krzysztof=20Skrz=C4=99tnicki?= Date: Thu, 9 Jan 2025 09:01:03 +0100 Subject: [PATCH 1/2] Make Teleport Connect use TCP connection mode for Oracle --- lib/teleterm/cmd/db.go | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/teleterm/cmd/db.go b/lib/teleterm/cmd/db.go index c18accc048b66..f984802f993f7 100644 --- a/lib/teleterm/cmd/db.go +++ b/lib/teleterm/cmd/db.go @@ -71,6 +71,7 @@ func newDBCLICommandWithExecer(ctx context.Context, cluster *clusters.Cluster, g dbcmd.WithNoTLS(), dbcmd.WithTolerateMissingCLIClient(), dbcmd.WithExecer(execer), + dbcmd.WithOracleOpts(true, true), dbcmd.WithGetDatabaseFunc(func(ctx context.Context, _ *client.TeleportClient, _ string) (types.Database, error) { getDatabaseOnce.Do(func() { database, getDatabaseError = cluster.GetDatabase(ctx, authClient, gateway.TargetURI()) From 392b5fe13bbf81b427dadbaac52a550f0e585a59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krzysztof=20Skrz=C4=99tnicki?= Date: Thu, 9 Jan 2025 13:00:09 +0100 Subject: [PATCH 2/2] Add comments to params --- lib/teleterm/cmd/db.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/teleterm/cmd/db.go b/lib/teleterm/cmd/db.go index f984802f993f7..144d386224c38 100644 --- a/lib/teleterm/cmd/db.go +++ b/lib/teleterm/cmd/db.go @@ -71,7 +71,7 @@ func newDBCLICommandWithExecer(ctx context.Context, cluster *clusters.Cluster, g dbcmd.WithNoTLS(), dbcmd.WithTolerateMissingCLIClient(), dbcmd.WithExecer(execer), - dbcmd.WithOracleOpts(true, true), + dbcmd.WithOracleOpts(true /* can use TCP */, true /* has TCP servers */), dbcmd.WithGetDatabaseFunc(func(ctx context.Context, _ *client.TeleportClient, _ string) (types.Database, error) { getDatabaseOnce.Do(func() { database, getDatabaseError = cluster.GetDatabase(ctx, authClient, gateway.TargetURI())