From 9eab2b8deb7f7d36078305c86c935106558b2e58 Mon Sep 17 00:00:00 2001 From: ThibaudAv Date: Thu, 17 Oct 2024 18:17:28 +0200 Subject: [PATCH] feat: ps - rework executionPhase & policy to use FlowPhase We need to keep PS compatible with all APIM < 4.6 --- ...io-ps-flow-details-phase-step.component.ts | 6 +- .../gio-ps-flow-details-phase.component.html | 2 +- .../gio-ps-flow-details-phase.component.ts | 6 +- .../gio-ps-flow-details.component.html | 12 +- ...-ps-policies-catalog-dialog.component.html | 4 +- ...-policies-catalog-dialog.component.spec.ts | 49 +++-- ...io-ps-policies-catalog-dialog.component.ts | 30 +-- .../gio-ps-policies-catalog-dialog.stories.ts | 28 +-- .../gio-ps-step-edit-dialog.component.html | 2 +- .../gio-ps-step-edit-dialog.component.spec.ts | 2 +- .../gio-ps-step-edit-dialog.component.ts | 8 +- .../gio-ps-step-edit-dialog.stories.ts | 2 +- .../step-form/gio-ps-step-form.component.ts | 10 +- .../src/lib/models/ApiProtocolType.ts | 17 ++ .../src/lib/models/{flow => }/ApiType.ts | 3 +- .../src/lib/models/flow/index.ts | 1 - .../src/lib/models/index.ts | 2 + .../src/lib/models/policy/Policy.fixture.ts | 84 ++++++--- .../src/lib/models/policy/Policy.ts | 50 ++++- .../policy/SharedPolicyGroupPolicy.fixture.ts | 4 +- .../models/policy/SharedPolicyGroupPolicy.ts | 6 +- .../gio-policy-group-studio.component.html | 2 +- .../gio-policy-group-studio.component.spec.ts | 177 +++++++++++++++++- .../gio-policy-group-studio.component.ts | 51 ++++- .../gio-policy-studio.component.ts | 16 +- 25 files changed, 444 insertions(+), 130 deletions(-) create mode 100644 projects/ui-policy-studio-angular/src/lib/models/ApiProtocolType.ts rename projects/ui-policy-studio-angular/src/lib/models/{flow => }/ApiType.ts (91%) diff --git a/projects/ui-policy-studio-angular/src/lib/components/flow-details-phase-step/gio-ps-flow-details-phase-step.component.ts b/projects/ui-policy-studio-angular/src/lib/components/flow-details-phase-step/gio-ps-flow-details-phase-step.component.ts index e77000891..ecc686003 100644 --- a/projects/ui-policy-studio-angular/src/lib/components/flow-details-phase-step/gio-ps-flow-details-phase-step.component.ts +++ b/projects/ui-policy-studio-angular/src/lib/components/flow-details-phase-step/gio-ps-flow-details-phase-step.component.ts @@ -27,7 +27,7 @@ import { GioPolicyStudioStepEditDialogData, GioPolicyStudioStepEditDialogResult, } from '../step-edit-dialog/gio-ps-step-edit-dialog.component'; -import { ExecutionPhase, isPolicy, isSharedPolicyGroupPolicy, Step, GenericPolicy } from '../../models'; +import { FlowPhase, isPolicy, isSharedPolicyGroupPolicy, Step, GenericPolicy } from '../../models'; @Component({ standalone: true, @@ -47,7 +47,7 @@ export class GioPolicyStudioDetailsPhaseStepComponent implements OnChanges { public genericPolicies: GenericPolicy[] = []; @Input({ required: true }) - public executionPhase!: ExecutionPhase; + public flowPhase!: FlowPhase; @Output() public stepChange = new EventEmitter(); @@ -120,7 +120,7 @@ ${this.policyNotFound === 'SHARED_POLICY_GROUP' ? 'Note: The Gateway will ignore readOnly: this.readOnly, genericPolicy: this.genericPolicy, step: this.step, - executionPhase: this.executionPhase, + flowPhase: this.flowPhase, }, role: 'alertdialog', id: 'gioPolicyStudioPolicyFormDialog', diff --git a/projects/ui-policy-studio-angular/src/lib/components/flow-details-phase/gio-ps-flow-details-phase.component.html b/projects/ui-policy-studio-angular/src/lib/components/flow-details-phase/gio-ps-flow-details-phase.component.html index b857796ee..55487f6c7 100644 --- a/projects/ui-policy-studio-angular/src/lib/components/flow-details-phase/gio-ps-flow-details-phase.component.html +++ b/projects/ui-policy-studio-angular/src/lib/components/flow-details-phase/gio-ps-flow-details-phase.component.html @@ -67,7 +67,7 @@ [class.disabled]="readOnly || !stepVM.step.enabled" [genericPolicies]="genericPolicies" [step]="stepVM.step" - [executionPhase]="policyExecutionPhase" + [flowPhase]="policyFlowPhase" (stepChange)="onStepChange(stepVM.index, $event)" (deleted)="onStepDeleted(stepVM.index)" (disabled)="onStepDisabled(stepVM.index)" diff --git a/projects/ui-policy-studio-angular/src/lib/components/flow-details-phase/gio-ps-flow-details-phase.component.ts b/projects/ui-policy-studio-angular/src/lib/components/flow-details-phase/gio-ps-flow-details-phase.component.ts index 707fe96a8..6c4bf12f8 100644 --- a/projects/ui-policy-studio-angular/src/lib/components/flow-details-phase/gio-ps-flow-details-phase.component.ts +++ b/projects/ui-policy-studio-angular/src/lib/components/flow-details-phase/gio-ps-flow-details-phase.component.ts @@ -26,7 +26,7 @@ import { GioPolicyStudioPoliciesCatalogDialogData, GioPolicyStudioPoliciesCatalogDialogResult, } from '../policies-catalog-dialog/gio-ps-policies-catalog-dialog.component'; -import { ApiType, ConnectorInfo, ExecutionPhase, Step } from '../../models'; +import { ApiType, ConnectorInfo, FlowPhase, Step } from '../../models'; import { GioPolicyStudioDetailsPhaseStepComponent } from '../flow-details-phase-step/gio-ps-flow-details-phase-step.component'; import { GenericPolicy } from '../../models/policy/GenericPolicy'; @@ -79,7 +79,7 @@ export class GioPolicyStudioDetailsPhaseComponent implements OnChanges { public genericPolicies: GenericPolicy[] = []; @Input() - public policyExecutionPhase!: ExecutionPhase; + public policyFlowPhase!: FlowPhase; @Input() public trialUrl?: string; @@ -136,7 +136,7 @@ export class GioPolicyStudioDetailsPhaseComponent implements OnChanges { >(GioPolicyStudioPoliciesCatalogDialogComponent, { data: { genericPolicies: this.genericPolicies, - executionPhase: this.policyExecutionPhase, + flowPhase: this.policyFlowPhase, apiType: this.apiType, trialUrl: this.trialUrl, }, diff --git a/projects/ui-policy-studio-angular/src/lib/components/flow-details/gio-ps-flow-details.component.html b/projects/ui-policy-studio-angular/src/lib/components/flow-details/gio-ps-flow-details.component.html index db9249778..6951b571a 100644 --- a/projects/ui-policy-studio-angular/src/lib/components/flow-details/gio-ps-flow-details.component.html +++ b/projects/ui-policy-studio-angular/src/lib/components/flow-details/gio-ps-flow-details.component.html @@ -59,7 +59,7 @@ [apiType]="apiType" [genericPolicies]="genericPolicies" [trialUrl]="trialUrl" - policyExecutionPhase="REQUEST" + policyFlowPhase="REQUEST" (stepsChange)="onStepsChange('request', $event)" > @@ -89,7 +89,7 @@ [apiType]="apiType" [genericPolicies]="genericPolicies" [trialUrl]="trialUrl" - policyExecutionPhase="MESSAGE_REQUEST" + policyFlowPhase="PUBLISH" (stepsChange)="onStepsChange('publish', $event)" > @@ -121,7 +121,7 @@ [apiType]="apiType" [genericPolicies]="genericPolicies" [trialUrl]="trialUrl" - policyExecutionPhase="REQUEST" + policyFlowPhase="REQUEST" (stepsChange)="onStepsChange('request', $event)" > diff --git a/projects/ui-policy-studio-angular/src/lib/components/policies-catalog-dialog/gio-ps-policies-catalog-dialog.component.html b/projects/ui-policy-studio-angular/src/lib/components/policies-catalog-dialog/gio-ps-policies-catalog-dialog.component.html index 127afca52..273f361f1 100644 --- a/projects/ui-policy-studio-angular/src/lib/components/policies-catalog-dialog/gio-ps-policies-catalog-dialog.component.html +++ b/projects/ui-policy-studio-angular/src/lib/components/policies-catalog-dialog/gio-ps-policies-catalog-dialog.component.html @@ -16,7 +16,7 @@ -->

- Policies for {{ executionPhaseLabel }} phase + Policies for {{ flowPhaseLabel }} phase