Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential missing labels in amenity-points #1091

Closed
matkoniecz opened this issue Oct 25, 2014 · 9 comments
Closed

Potential missing labels in amenity-points #1091

matkoniecz opened this issue Oct 25, 2014 · 9 comments

Comments

@matkoniecz
Copy link
Contributor

Following objects are rendered as nodes on z20, but without labels for name tag

amenity=atm
amenity=bicycle_rental
highway=ford
tourism=information
lock=yes
man_made=mast
amenity=post_box
amenity=recycling
amenity=telephone
amenity=emergency_phone
amenity=toilets
amenity=drinking_water
man_made=water_tower
tourism=picnic_site
leisure=picnic_table
leisure=slipway
tourism=caravan_site

I think that man_made=mast and highway=ford may have labels, I am less sure about other positions.

In addition #459 is ticket for tourism=viewpoint, #840 amenity=post_office, #800 amenity=car_sharing

related to #710

@matthijsmelissen
Copy link
Collaborator

tourism=caravan_site does in fact have a label. I am looking at lock=yes in #991.

For the others, you could look at http://overpass-turbo.eu/ to see whether the names that are in use (if any) make sense to render.

Query:

[out:json][timeout:25];
// gather results
(
  // query part for: “amenity=atm”
  node["amenity"="atm"]["name"]({{bbox}});
  way["amenity"="atm"]["name"]({{bbox}});
  relation["amenity"="atm"]["name"]({{bbox}});
);
// print results
out body;
>;
out skel qt;

@HolgerJeromin
Copy link
Contributor

Some are better with a brand. Post related for example

@matkoniecz
Copy link
Contributor Author

tourism=caravan_site does in fact have a label

Thanks for catching (it has but it is never displayed, as text-dy is not defined). I removed it from list and added it to my current PR, so there is no need for a separate ticket.

@dieterdreist
Copy link

2014-10-25 19:13 GMT+02:00 Mateusz Konieczny notifications@github.com:

I think that man_made=mast and highway=ford may have labels, I am less
sure about other position.

lock=yes seems to be an attribute for a waterway inside a lock similar to
bridge=yes on highways, I think it would be better to have a dedicated lock
object and render the name of this (e.g. a polygon object).
from the list, I'd expect also bicycle_rental, caravan_site, mast, lock,
recycling centers (but not containers), water towers and picnic sites to
have names (occasionally at least).

For post boxes and telephones it might make sense to render brand and/or
operator (but only on z19 to avoid cluttering).

I'm undecided for leisure=slipway (I'd guess they are typically part of a
bigger structure like a marina for which we do render the name),
amenity=drinking_water (personally I'd use amenity=fountain and
drinkable=yes when there is a name or a significant structure with
different scope than just dispensing water) but in doubt I'd add support
for evventually present names.

For recycling containers it might be interesting to see what kind of
container there is (glass, paper, plastic etc.).

@HolgerJeromin
Copy link
Contributor

Rendering names of recycling containers would lead us to "glass", "paper" as a name. Colouring them was rejected as #842. So perhaps these object should not get a name right now before solving the type visibility problem.

@dieterdreist
Copy link

2014-10-27 14:47 GMT+01:00 Holger Jeromin notifications@github.com:

Rendering names of recycling containers would lead us to "glass", "paper"
as a name. Colouring them was rejected as #842
#842. So
perhaps these object should not get a name right now before solving the
type visibility problem.

it is important to distinguish between a simple container along the road
(in some areas there are containers every 50 metres or even for every
building, several of them for the different types of material) and a
recycling centre, which can be a very big factory like plant, because the
god of tagging has decided that those get the same main tag and will be
distinguished only by a separate subtag.
I see nothing bad in having text like "paper" or "glass" in very high zoom
levels beneath a recycling symbol.

@pnorman
Copy link
Collaborator

pnorman commented Oct 28, 2014

Rendering names of recycling containers would lead us to "glass", "paper" as a name.

I don't like the idea of language-specific labels - but this is out of scope for rendering more names. If you feel that non-name text should be added, you could open up a new issue.

@matkoniecz matkoniecz added this to the Bugs and improvements milestone Oct 28, 2014
@matkoniecz matkoniecz self-assigned this Oct 29, 2014
@matthijsmelissen
Copy link
Collaborator

The tag amenity=recycling in the database usually has 'real' a name tag, the name of the recycling centre. I agree values like 'glass', 'paper' etc should not be used as name tag.

Bicycle rental, mast, recycling, drinking_water, water_tower, picnic_site, picnic_table, and slipway often have real names in the database. For atm, we can render the operator.

Ford, post box, telephone, emergency_phone, and toilets usually don't have a name so I propose to not render a label for them.

Tourism=information need access to the information key, see #304.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 22, 2015
Add labels for:
* amenity=post_office (resolves gravitystorm#840)
* natural=tree (resolves gravitystorm#801)
* amenity=car_sharing (operator, resolves gravitystorm#880)
* amenity=atm (operator)
* amenity=bicycle_rental
* man_made=mast
* amenity=recycling
* amenity=drinking_water
* man_made=water_tower
* tourism=picnic_site
* leisure=picnic_table
* leisure=slipway

Resolves gravitystorm#1091.
@HolgerJeromin
Copy link
Contributor

We will see if your pull request will make the mappers use fake names for recycling containers.
Thanks btw for adding names for trees :-)

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 26, 2015
Add labels for:
* amenity=post_office (resolves gravitystorm#840)
* natural=tree (resolves gravitystorm#801)
* amenity=car_sharing (operator, resolves gravitystorm#880)
* amenity=atm (operator)
* amenity=bicycle_rental
* man_made=mast
* amenity=recycling
* amenity=drinking_water
* man_made=water_tower
* tourism=picnic_site
* leisure=picnic_table
* leisure=slipway

Resolves gravitystorm#1091.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Apr 27, 2015
Add labels for:
* amenity=post_office (resolves gravitystorm#840)
* natural=tree (resolves gravitystorm#801)
* amenity=car_sharing (operator, resolves gravitystorm#880)
* amenity=atm (operator)
* amenity=bicycle_rental
* man_made=mast
* amenity=recycling
* amenity=drinking_water
* man_made=water_tower
* tourism=picnic_site
* leisure=picnic_table
* leisure=slipway

Resolves gravitystorm#1091.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Apr 29, 2015
Add labels for:
* amenity=post_office (resolves gravitystorm#840)
* natural=tree (resolves gravitystorm#801)
* amenity=car_sharing (operator, resolves gravitystorm#880)
* amenity=atm (operator)
* amenity=bicycle_rental
* man_made=mast
* amenity=recycling
* amenity=drinking_water
* man_made=water_tower
* tourism=picnic_site
* leisure=picnic_table
* leisure=slipway

Resolves gravitystorm#1091.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants