-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show empty sections in result details #2791
Don't show empty sections in result details #2791
Conversation
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2791 +/- ##
=============================================
- Coverage 53.83% 53.82% -0.01%
=============================================
Files 1075 1075
Lines 26226 26227 +1
Branches 7491 7492 +1
=============================================
- Hits 14118 14116 -2
- Misses 10993 10996 +3
Partials 1115 1115
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this change too but could you please also fix the models to set undefined if an empty string is used in these tags. Such things should to be fixed in the parsing part (model) to avoid having to implement this meaning of empty string at several places in the view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicked on the wrong item. Should have been a Request changes.
c9264b2
to
104fb97
Compare
Co-authored-by: Björn Ricks <bjoern.ricks@greenbone.net>
Don't show empty sections in result details (bp #2791)
What:
Parse empty strings in NVT tags as undefined.
Why:
Instead of undefined information we got an empty string before. This fixes showing empty sections on the result details.
How:
Check data in dev-tools and visually inspect whether the sections are no longer visible if there is no information. Added an automated test for the empty string case.
Checklist: